Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb@sourceware.org, ktietz@redhat.com,
	       cgf-use-the-mailinglist-please@gnu.org
Subject: Re: readline rebase 5.1->6.2?
Date: Tue, 22 Mar 2011 19:48:00 -0000	[thread overview]
Message-ID: <20110322194836.GA23104@host1.jankratochvil.net> (raw)
In-Reply-To: <83tyev7z7a.fsf@gnu.org>

On Tue, 22 Mar 2011 20:05:45 +0100, Eli Zaretskii wrote:
> > Just the patches are of the kind of MS-related platforms compatibility:
> > 	+dnl BEGIN changes for CYGNUS cross-building for Cygwin
> > 	+#ifdef __MSDOS__
> > 	+#if defined (__GO32__)
> > 	+#ifndef __MINGW32__
> > 	!+#if defined (SIGWINCH)
> > 	? (+#if defined (HAVE_GETPWENT))
> 
> I'm not sure I understand: are you saying that the local patches we
> have in GDB wrt the original readline 5.1 are those listed above?  If
> so, the last two are not about MS platforms.

The patch for SIGWINCH applies for the case when SIGWINCH is not defined
- which happens only on some non-UNIX platforms I guess, I do not know if on
MS platforms.

With HAVE_GETPWENT you are right that patch may be completely unrelated to the
MS platforms.


> Can you show these patches in full?

I do not have anything else than you have.  I just used diff on
	ftp://ftp.cwru.edu/pub/bash/readline-5.1.tar.gz
vs. src/readline.  But one should rather check individual patches
with git annotate / git show etc. and compare them against readline-6.2.


Thanks,
Jan


  reply	other threads:[~2011-03-22 19:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 15:43 Jan Kratochvil
2011-03-22 16:43 ` Joel Brobecker
2011-03-22 16:58 ` Tom Tromey
2011-03-22 17:19 ` Kai Tietz
2011-03-22 19:05 ` Eli Zaretskii
2011-03-22 19:48   ` Jan Kratochvil [this message]
2011-03-22 19:59     ` Eli Zaretskii
2011-04-01  9:30       ` Eli Zaretskii
2011-04-01 14:19         ` Tom Tromey
2011-04-02 10:29           ` Eli Zaretskii
2011-04-03  3:01             ` Eli Zaretskii
2011-04-25 16:05               ` Jan Kratochvil
2011-04-02 20:10         ` Jan Kratochvil
2011-03-22 20:04     ` Tom Tromey
2011-04-01  9:25       ` Eli Zaretskii
2011-03-22 20:36     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322194836.GA23104@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=cgf-use-the-mailinglist-please@gnu.org \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    --cc=ktietz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox