From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25390 invoked by alias); 22 Mar 2011 19:48:54 -0000 Received: (qmail 25381 invoked by uid 22791); 22 Mar 2011 19:48:52 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Mar 2011 19:48:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2MJmea6023336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Mar 2011 15:48:40 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2MJmcth002713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Mar 2011 15:48:39 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p2MJmbcv006144; Tue, 22 Mar 2011 20:48:37 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p2MJmaGX006138; Tue, 22 Mar 2011 20:48:36 +0100 Date: Tue, 22 Mar 2011 19:48:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb@sourceware.org, ktietz@redhat.com, cgf-use-the-mailinglist-please@gnu.org Subject: Re: readline rebase 5.1->6.2? Message-ID: <20110322194836.GA23104@host1.jankratochvil.net> References: <20110322154327.GA8966@host1.jankratochvil.net> <83tyev7z7a.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83tyev7z7a.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00125.txt.bz2 On Tue, 22 Mar 2011 20:05:45 +0100, Eli Zaretskii wrote: > > Just the patches are of the kind of MS-related platforms compatibility: > > +dnl BEGIN changes for CYGNUS cross-building for Cygwin > > +#ifdef __MSDOS__ > > +#if defined (__GO32__) > > +#ifndef __MINGW32__ > > !+#if defined (SIGWINCH) > > ? (+#if defined (HAVE_GETPWENT)) > > I'm not sure I understand: are you saying that the local patches we > have in GDB wrt the original readline 5.1 are those listed above? If > so, the last two are not about MS platforms. The patch for SIGWINCH applies for the case when SIGWINCH is not defined - which happens only on some non-UNIX platforms I guess, I do not know if on MS platforms. With HAVE_GETPWENT you are right that patch may be completely unrelated to the MS platforms. > Can you show these patches in full? I do not have anything else than you have. I just used diff on ftp://ftp.cwru.edu/pub/bash/readline-5.1.tar.gz vs. src/readline. But one should rather check individual patches with git annotate / git show etc. and compare them against readline-6.2. Thanks, Jan