From: Pedro Alves <pedro@codesourcery.com>
To: gdb@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
stefano.sabatini-lala@poste.it
Subject: Re: pthread_t ids of threads not showed by "thread info"
Date: Wed, 04 Aug 2010 18:20:00 -0000 [thread overview]
Message-ID: <201008041920.23655.pedro@codesourcery.com> (raw)
In-Reply-To: <201008041744.o74HiVCJ022771@d12av02.megacenter.de.ibm.com>
On Wednesday 04 August 2010 18:44:31, Ulrich Weigand wrote:
> Pedro Alves wrote:
>
> > > Thanks. We can then just call linux_init_abi at the top of
> > > s390_gdbarch_init, right?
> >
> > Or rather, a bit further down, where the gdbarch is actually
> > created, like so?
>
> Actually, I think it should be rather at the end, where other
> architectures which support multiple OSABIs call gdbarch_init_osabi.
>
> That way, at least basic setup of the architecture is already done
> when the osabi routine is called ...
Ah, agreed. I've now placed it just above some core file and other
OS specific-ish bits, although there are a few non-OS things
mingled a bit below too.
(OOC, I wonder whether there's anything technically preventing
installing an GDB_OSABI_LINUX osabi callback and move
these linux related bits there, to keep things neat.)
> Oh, something else:
>
> > * s390-tdep.c: Include linux-tdep.h.
>
> The patch you posted doesn't :-)
Bah, sorry, forgot to "quilt refresh" before copy&paste. :-)
Let try once more...
--
Pedro Alves
2010-08-04 Pedro Alves <pedro@codesourcery.com>
* s390-tdep.c: Include linux-tdep.h.
(s390_gdbarch_init): Call linux_init_abi.
---
gdb/s390-tdep.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Index: src/gdb/s390-tdep.c
===================================================================
--- src.orig/gdb/s390-tdep.c 2010-08-04 18:48:44.000000000 +0100
+++ src/gdb/s390-tdep.c 2010-08-04 19:06:27.000000000 +0100
@@ -43,7 +43,7 @@
#include "dis-asm.h"
#include "solib-svr4.h"
#include "prologue-value.h"
-
+#include "linux-tdep.h"
#include "s390-tdep.h"
#include "features/s390-linux32.c"
@@ -2909,6 +2909,10 @@ s390_gdbarch_init (struct gdbarch_info i
displaced_step_at_entry_point);
set_gdbarch_max_insn_length (gdbarch, S390_MAX_INSTR_SIZE);
+ /* Note that GNU/Linux is the only OS supported on this
+ platform. */
+ linux_init_abi (info, gdbarch);
+
switch (tdep->abi)
{
case ABI_LINUX_S390:
next prev parent reply other threads:[~2010-08-04 18:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 15:19 Stefano Sabatini
2010-04-22 15:44 ` Stefano Sabatini
2010-04-22 16:59 ` Jan Kratochvil
2010-04-23 7:51 ` Stefano Sabatini
2010-04-23 10:25 ` Jan Kratochvil
2010-04-23 14:21 ` Stefano Sabatini
2010-04-23 14:25 ` Jan Kratochvil
2010-04-23 15:36 ` Stefano Sabatini
2010-04-23 15:46 ` Jan Kratochvil
2010-04-26 8:38 ` Stefano Sabatini
2010-04-26 9:04 ` Jan Kratochvil
2010-04-26 11:07 ` Stefano Sabatini
2010-04-26 11:25 ` Jan Kratochvil
2010-04-23 14:29 ` Stefano Sabatini
2010-04-23 11:50 ` Pedro Alves
2010-04-23 12:31 ` Mark Kettenis
2010-04-23 12:47 ` Pedro Alves
2010-04-23 15:37 ` Mark Kettenis
2010-04-23 15:51 ` Pedro Alves
2010-08-04 14:36 ` Pedro Alves
2010-08-04 14:57 ` Mark Kettenis
2010-08-04 15:29 ` Pedro Alves
2010-08-04 16:53 ` Ulrich Weigand
2010-08-04 17:14 ` Pedro Alves
2010-08-04 17:40 ` Pedro Alves
2010-08-04 17:44 ` Ulrich Weigand
2010-08-04 18:20 ` Pedro Alves [this message]
2010-08-04 18:34 ` Ulrich Weigand
2010-08-04 20:41 ` Pedro Alves
2010-08-04 17:45 ` Ulrich Weigand
2010-04-22 20:52 ` Petr Hluzín
2010-04-22 20:56 ` Daniel Jacobowitz
2010-08-18 14:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008041920.23655.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=stefano.sabatini-lala@poste.it \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox