From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19995 invoked by alias); 4 Aug 2010 18:20:33 -0000 Received: (qmail 19984 invoked by uid 22791); 4 Aug 2010 18:20:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Aug 2010 18:20:28 +0000 Received: (qmail 26362 invoked from network); 4 Aug 2010 18:20:26 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Aug 2010 18:20:26 -0000 From: Pedro Alves To: gdb@sourceware.org Subject: Re: pthread_t ids of threads not showed by "thread info" Date: Wed, 04 Aug 2010 18:20:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.31-11-rt; KDE/4.4.2; x86_64; ; ) Cc: "Ulrich Weigand" , Mark Kettenis , stefano.sabatini-lala@poste.it References: <201008041744.o74HiVCJ022771@d12av02.megacenter.de.ibm.com> In-Reply-To: <201008041744.o74HiVCJ022771@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008041920.23655.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00033.txt.bz2 On Wednesday 04 August 2010 18:44:31, Ulrich Weigand wrote: > Pedro Alves wrote: > > > > Thanks. We can then just call linux_init_abi at the top of > > > s390_gdbarch_init, right? > > > > Or rather, a bit further down, where the gdbarch is actually > > created, like so? > > Actually, I think it should be rather at the end, where other > architectures which support multiple OSABIs call gdbarch_init_osabi. > > That way, at least basic setup of the architecture is already done > when the osabi routine is called ... Ah, agreed. I've now placed it just above some core file and other OS specific-ish bits, although there are a few non-OS things mingled a bit below too. (OOC, I wonder whether there's anything technically preventing installing an GDB_OSABI_LINUX osabi callback and move these linux related bits there, to keep things neat.) > Oh, something else: > > > * s390-tdep.c: Include linux-tdep.h. > > The patch you posted doesn't :-) Bah, sorry, forgot to "quilt refresh" before copy&paste. :-) Let try once more... -- Pedro Alves 2010-08-04 Pedro Alves * s390-tdep.c: Include linux-tdep.h. (s390_gdbarch_init): Call linux_init_abi. --- gdb/s390-tdep.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Index: src/gdb/s390-tdep.c =================================================================== --- src.orig/gdb/s390-tdep.c 2010-08-04 18:48:44.000000000 +0100 +++ src/gdb/s390-tdep.c 2010-08-04 19:06:27.000000000 +0100 @@ -43,7 +43,7 @@ #include "dis-asm.h" #include "solib-svr4.h" #include "prologue-value.h" - +#include "linux-tdep.h" #include "s390-tdep.h" #include "features/s390-linux32.c" @@ -2909,6 +2909,10 @@ s390_gdbarch_init (struct gdbarch_info i displaced_step_at_entry_point); set_gdbarch_max_insn_length (gdbarch, S390_MAX_INSTR_SIZE); + /* Note that GNU/Linux is the only OS supported on this + platform. */ + linux_init_abi (info, gdbarch); + switch (tdep->abi) { case ABI_LINUX_S390: