Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: muller@ics.u-strasbg.fr (Pierre Muller)
Cc: brobecker@adacore.com ('Joel Brobecker'),
	gdb-patches@sourceware.org,         gdb@sourceware.org,
	eliz@gnu.org ('Eli Zaretskii')
Subject: Re: [RFC] GDB ARIndex Linux rule cleanup
Date: Wed, 15 Apr 2009 14:19:00 -0000	[thread overview]
Message-ID: <200904151400.n3FE0div003099@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <007301c9bd55$a66e8320$f34b8960$@u-strasbg.fr> from "Pierre Muller" at Apr 15, 2009 01:06:30 AM

Pierre Muller wrote:

> Index: ppc-linux-tdep.c
> ===================================================================

> -/* Wrappers to handle Linux-only registers.  */
> +/* Wrappers to handle Linux-only kernel registers.  */

> -  /* Initialize the Linux target descriptions.  */
> +  /* Initialize the Linux kernel target descriptions.  */

> Index: ppc-linux-tdep.h
> ===================================================================

> -/* Linux target descriptions.  */
> +/* Linux kernel target descriptions.  */


It seems to me that in *those* cases, we should actually use
GNU/Linux instead -- this is talking about GDB target support
for the GNU/Linux operating system on PowerPC, and not specifically
related to the kernel only (for example, those target descriptions
are also used when analysing a core file on a remote system).

Compare for example the usage in linux-nat.c:

/* Create a prototype generic GNU/Linux target.  


The other instances in your patch, where a kernel version
is specifically named, clearly refer to the Linux kernel.

I'd be fine with adding "kernel" to the text here; but I
also agree with Eli's suggestion that it might be even 
better to have the ARI script recognize use of a version
number ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2009-04-15 14:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 13:10 GDB ARIndex cleanup Pierre Muller
2009-03-26 20:10 ` Eli Zaretskii
2009-03-27  8:13   ` Pierre Muller
2009-03-27  8:43     ` Eli Zaretskii
2009-03-26 23:10 ` Joel Brobecker
2009-03-27  2:19   ` Daniel Jacobowitz
2009-03-27  8:23   ` Pierre Muller
2009-03-27 16:00     ` Joel Brobecker
2009-03-27 16:36       ` Daniel Jacobowitz
2009-04-14 23:23   ` [RFC] GDB ARIndex Linux rule cleanup Pierre Muller
2009-04-14 23:38     ` Mark Kettenis
2009-04-14 23:41       ` Pedro Alves
2009-04-15  0:27         ` Joel Brobecker
2009-04-15  7:33           ` Pierre Muller
2009-04-15 14:00           ` Eli Zaretskii
2009-04-15 14:19     ` Ulrich Weigand [this message]
2009-04-15 14:25       ` Pedro Alves
2009-04-15 15:34         ` Ulrich Weigand
2009-04-15 15:59           ` Pedro Alves
2009-04-15 15:15       ` Eli Zaretskii
2009-04-15 15:23         ` Daniel Jacobowitz
2009-04-15 15:32         ` Ulrich Weigand
2009-04-15 15:54           ` Mark Kettenis
2009-04-15 16:04             ` Eli Zaretskii
2009-04-15 16:11           ` Eli Zaretskii
2009-04-15 18:07             ` Ulrich Weigand
2009-04-15 18:55               ` Eli Zaretskii
2009-04-15 19:48                 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904151400.n3FE0div003099@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox