From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>,
gdb-patches@sourceware.org, gdb@sourceware.org,
'Eli Zaretskii' <eliz@gnu.org>
Subject: Re: GDB ARIndex cleanup
Date: Fri, 27 Mar 2009 02:19:00 -0000 [thread overview]
Message-ID: <20090327021949.GB29050@caradoc.them.org> (raw)
In-Reply-To: <20090326230959.GN9472@adacore.com>
On Thu, Mar 26, 2009 at 04:09:59PM -0700, Joel Brobecker wrote:
> > 1) "inline"
> > for inline, someone once said that the rule that we should not use
> > "inline" keyword is old, and maybe not correct anymore.
> >
> > If everyone agrees that this rule should stay, I will be happy to
> > commit an obvious fix removing all of them as this seems quite
> > mechanical, but I wanted to get some feedback first.
>
> I don't know much about the effectiveness of using "inline".
> I personally tend to avoid it, because I trust the compiler to determine
> whether an inline will help or not. So I'm OK either way.
My two cents: in practice, it's still useful. I don't think we need a
rule banning it.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-03-27 2:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 13:10 Pierre Muller
2009-03-26 20:10 ` Eli Zaretskii
2009-03-27 8:13 ` Pierre Muller
2009-03-27 8:43 ` Eli Zaretskii
2009-03-26 23:10 ` Joel Brobecker
2009-03-27 2:19 ` Daniel Jacobowitz [this message]
2009-03-27 8:23 ` Pierre Muller
2009-03-27 16:00 ` Joel Brobecker
2009-03-27 16:36 ` Daniel Jacobowitz
2009-04-14 23:23 ` [RFC] GDB ARIndex Linux rule cleanup Pierre Muller
2009-04-14 23:38 ` Mark Kettenis
2009-04-14 23:41 ` Pedro Alves
2009-04-15 0:27 ` Joel Brobecker
2009-04-15 7:33 ` Pierre Muller
2009-04-15 14:00 ` Eli Zaretskii
2009-04-15 14:19 ` Ulrich Weigand
2009-04-15 14:25 ` Pedro Alves
2009-04-15 15:34 ` Ulrich Weigand
2009-04-15 15:59 ` Pedro Alves
2009-04-15 15:15 ` Eli Zaretskii
2009-04-15 15:23 ` Daniel Jacobowitz
2009-04-15 15:32 ` Ulrich Weigand
2009-04-15 15:54 ` Mark Kettenis
2009-04-15 16:04 ` Eli Zaretskii
2009-04-15 16:11 ` Eli Zaretskii
2009-04-15 18:07 ` Ulrich Weigand
2009-04-15 18:55 ` Eli Zaretskii
2009-04-15 19:48 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327021949.GB29050@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox