* ^m's in testsuite/gdb.disasm
@ 2007-10-31 19:21 Doug Evans
2007-10-31 20:19 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Doug Evans @ 2007-10-31 19:21 UTC (permalink / raw)
To: gdb
I can understand ^m's in djunpack.bat, but I'm curious if there's any global
rule regarding ^m's appearing elsewhere. I ask because the following files
have ^m's and it resulting in spurious differences when trying to compare
trees. One program I used to create a tree was dos-vs-unix aware and stripped
them. On the one hand "my bad" and I'd expect to pay the price if I try to use
djunpack.bat, but OTOH IWBN to avoid the issue where possible and just stick
with ^j for newlines, even in the testsuite. OTOOH, if the ^m's are
intentional, no problem - but a README to that effect in the same directory
would be nice.
Just my $0.02.
gdb/testsuite/gdb.disasm/t01_mov.s
gdb/testsuite/gdb.disasm/t02_mova.s
gdb/testsuite/gdb.disasm/t03_add.s
gdb/testsuite/gdb.disasm/t04_sub.s
gdb/testsuite/gdb.disasm/t05_cmp.s
gdb/testsuite/gdb.disasm/t06_ari2.s
gdb/testsuite/gdb.disasm/t07_ari3.s
gdb/testsuite/gdb.disasm/t08_or.s
gdb/testsuite/gdb.disasm/t09_xor.s
gdb/testsuite/gdb.disasm/t10_and.s
gdb/testsuite/gdb.disasm/t11_logs.s
gdb/testsuite/gdb.disasm/t12_bit.s
gdb/testsuite/gdb.disasm/t13_otr.s
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ^m's in testsuite/gdb.disasm
2007-10-31 19:21 ^m's in testsuite/gdb.disasm Doug Evans
@ 2007-10-31 20:19 ` Eli Zaretskii
2007-10-31 20:22 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2007-10-31 20:19 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb
> Date: Wed, 31 Oct 2007 12:21:47 -0700 (PDT)
> From: dje@google.com (Doug Evans)
>
> I can understand ^m's in djunpack.bat, but I'm curious if there's any global
> rule regarding ^m's appearing elsewhere.
Any *.bat or *.cmd files should have DOS-style CR-LF line endings.
As for other files, IMO they should only have CR-LF if the development
tools or programs that use them require that. I don't think *.s
assembly source files qualify; chances are they were simply committed
from a Windows machine...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ^m's in testsuite/gdb.disasm
2007-10-31 20:19 ` Eli Zaretskii
@ 2007-10-31 20:22 ` Daniel Jacobowitz
2007-10-31 20:36 ` frank.theinen
2007-11-01 23:45 ` Douglas Evans
0 siblings, 2 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2007-10-31 20:22 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Doug Evans, gdb
On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii wrote:
> As for other files, IMO they should only have CR-LF if the development
> tools or programs that use them require that. I don't think *.s
> assembly source files qualify; chances are they were simply committed
> from a Windows machine...
I agree; I suspect it's just an accident.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ^m's in testsuite/gdb.disasm
2007-10-31 20:22 ` Daniel Jacobowitz
@ 2007-10-31 20:36 ` frank.theinen
2007-11-01 23:45 ` Douglas Evans
1 sibling, 0 replies; 6+ messages in thread
From: frank.theinen @ 2007-10-31 20:36 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: Doug Evans, Eli Zaretskii, gdb
> On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii wrote:
> > As for other files, IMO they should only have CR-LF if the development
> > tools or programs that use them require that. I don't think *.s
> > assembly source files qualify; chances are they were simply committed
> > from a Windows machine...
>
> I agree; I suspect it's just an accident.
FWIW: By coincidence we had a similar event in our company CVS repository:
Whereas checking out and committing from a Windows machine presented no
problems since CVS does automatic end of line conversion on ASCII files
(-kkv), using the editor Kate under Linux configured to use CR-LF style
endings managed to trick CVS, so that the files in the repository got the
CR-LF line endings.
Regards, Frank
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ^m's in testsuite/gdb.disasm
2007-10-31 20:22 ` Daniel Jacobowitz
2007-10-31 20:36 ` frank.theinen
@ 2007-11-01 23:45 ` Douglas Evans
2007-11-02 0:38 ` Daniel Jacobowitz
1 sibling, 1 reply; 6+ messages in thread
From: Douglas Evans @ 2007-11-01 23:45 UTC (permalink / raw)
To: gdb
On Oct 31, 2007 1:22 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii wrote:
> > As for other files, IMO they should only have CR-LF if the development
> > tools or programs that use them require that. I don't think *.s
> > assembly source files qualify; chances are they were simply committed
> > from a Windows machine...
>
> I agree; I suspect it's just an accident.
Thanks. Can I check in a fix?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ^m's in testsuite/gdb.disasm
2007-11-01 23:45 ` Douglas Evans
@ 2007-11-02 0:38 ` Daniel Jacobowitz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2007-11-02 0:38 UTC (permalink / raw)
To: Douglas Evans; +Cc: gdb
On Thu, Nov 01, 2007 at 04:44:57PM -0700, Douglas Evans wrote:
> On Oct 31, 2007 1:22 PM, Daniel Jacobowitz <drow@false.org> wrote:
> > On Wed, Oct 31, 2007 at 10:18:51PM +0200, Eli Zaretskii wrote:
> > > As for other files, IMO they should only have CR-LF if the development
> > > tools or programs that use them require that. I don't think *.s
> > > assembly source files qualify; chances are they were simply committed
> > > from a Windows machine...
> >
> > I agree; I suspect it's just an accident.
>
> Thanks. Can I check in a fix?
Please do!
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-11-02 0:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-31 19:21 ^m's in testsuite/gdb.disasm Doug Evans
2007-10-31 20:19 ` Eli Zaretskii
2007-10-31 20:22 ` Daniel Jacobowitz
2007-10-31 20:36 ` frank.theinen
2007-11-01 23:45 ` Douglas Evans
2007-11-02 0:38 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox