From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Daniel Jacobowitz <drow@false.org>, gdb@sourceware.org
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Date: Sat, 09 Jun 2007 19:29:00 -0000 [thread overview]
Message-ID: <20070609192835.GA25350@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <18019.29775.303769.331474@kahikatea.snap.net.nz>
On Mon, 04 Jun 2007 04:09:19 +0200, Nick Roberts wrote:
...
> > I'm not sure how to fix it, either -
> > the patch you cited was very tricky to come up with already :-(
The whole reason why the patch was so tricky was giving up on using the
synchronous readline () call. Replacing it with the other callbacked
possibilities is not going to be backward compatible as readline () behavior is
too complex.
Going to provide a libreadline patch #2 but unfortunately only later.
> I've not read the thread (it looked quite long) but the problem the patch
> fixes (which seems to be for CLI, not TUI) doesn't seem important enough
> to justify such an invasive change (apologies, if it fixed further problems).
>
> For now, could you please just revert it?
Voting for its temporary removal (and it is going to be done for Red Hat GDB).
Regards,
Jan
next prev parent reply other threads:[~2007-06-09 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 22:54 Nick Roberts
2007-06-03 23:10 ` Andreas Schwab
2007-06-03 23:13 ` Andreas Schwab
2007-06-04 1:06 ` Daniel Jacobowitz
2007-06-04 2:09 ` Nick Roberts
2007-06-09 19:29 ` Jan Kratochvil [this message]
2007-06-10 1:02 ` Asynchronous Gdb [was Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list] Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070609192835.GA25350@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=drow@false.org \
--cc=gdb@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox