From: Joel Brobecker <brobecker@adacore.com>
To: gdb@sourceware.org
Subject: symfile.h missing "#include "symtab.h" ?
Date: Wed, 21 Mar 2007 00:45:00 -0000 [thread overview]
Message-ID: <20070321004620.GD21799@adacore.com> (raw)
Hello,
I noticed this today: If I include symfile.h without including
symtab.h first, I get a compilation error because domain_enum
is not defined.
I was about to send a patch to add the missing include, but then
noticed:
/* This file requires that you first include "bfd.h". */
Is this something we're intending to keep? Shouldn't we just
add the "#include "bfd.h" in that file? If not, then should we
treat "symtab.h" the same way?
Let me know what is prefered and I'll send a tested patch on thurday.
Thanks,
--
Joel
next reply other threads:[~2007-03-21 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 0:45 Joel Brobecker [this message]
2007-03-21 1:54 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321004620.GD21799@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox