From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10721 invoked by alias); 21 Mar 2007 00:45:36 -0000 Received: (qmail 10647 invoked by uid 22791); 21 Mar 2007 00:45:35 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 21 Mar 2007 00:45:30 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 65A8F48CFD6 for ; Tue, 20 Mar 2007 20:45:28 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22238-01-2 for ; Tue, 20 Mar 2007 20:45:28 -0400 (EDT) Received: from joel.gnat.com (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 1262748CFD4 for ; Tue, 20 Mar 2007 20:45:28 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C44F4E7B39; Tue, 20 Mar 2007 17:46:20 -0700 (PDT) Date: Wed, 21 Mar 2007 00:45:00 -0000 From: Joel Brobecker To: gdb@sourceware.org Subject: symfile.h missing "#include "symtab.h" ? Message-ID: <20070321004620.GD21799@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00236.txt.bz2 Hello, I noticed this today: If I include symfile.h without including symtab.h first, I get a compilation error because domain_enum is not defined. I was about to send a patch to add the missing include, but then noticed: /* This file requires that you first include "bfd.h". */ Is this something we're intending to keep? Shouldn't we just add the "#include "bfd.h" in that file? If not, then should we treat "symtab.h" the same way? Let me know what is prefered and I'll send a tested patch on thurday. Thanks, -- Joel