Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
	Wiljan.Derks@zonnet.nl, 	gdb@sourceware.org
Subject: Re: How to tell gdb about dlls using remote protocol
Date: Wed, 14 Feb 2007 08:51:00 -0000	[thread overview]
Message-ID: <20070213193222.GB32195@adacore.com> (raw)
In-Reply-To: <20070208230033.GB4258@nevyn.them.org>

> >       else if (cache->pc == 0 && frame_pc_unwind (next_frame) != 0)
> > 
> > What do you think of that?
> 
> Can we actually check for a failure to find the start address?  Using
> pc == 0 is unfortunate - we keep encountering people who link code at
> zero.

The problem is in the way we designed frame_func_unwind: It returns
zero if we couldn't find the function start, which cannot be
differentiated from the case where the function actually starts at
address zero (which I didn't think I would ever encounter).

I think in the long term, we might want to adjust frame_func_unwind
to return a be something like:

   int frame_func_unwind (struct frame_info *fi, CORE_ADDR *addr)

The return value would be non-zero only if the function could be
found.

In the short-term, Mark's proposal seems a good way to make progress
for little cost.

> Oh, I guess there's no way; we already use the pc != 0 check in the
> same function.

Yep, same issue.

-- 
Joel


      reply	other threads:[~2007-02-13 19:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 21:08 Wiljan Derks
2007-01-31 22:31 ` Daniel Jacobowitz
2007-02-01 17:52   ` Joel Brobecker
2007-02-01 22:54     ` Daniel Jacobowitz
2007-02-01 23:02       ` Joel Brobecker
2007-02-01 23:59         ` Daniel Jacobowitz
2007-02-02  6:20           ` Robert Dewar
2007-02-02 11:43             ` Daniel Jacobowitz
2007-02-02 16:51               ` Joel Brobecker
2007-02-02 16:56                 ` Daniel Jacobowitz
2007-02-02 17:34                   ` Joel Brobecker
2007-02-05 20:34                     ` Wiljan Derks
2007-02-05 21:21                       ` Joel Brobecker
2007-02-07 21:47                     ` Mark Kettenis
2007-02-07 22:14     ` Mark Kettenis
2007-02-07 22:17       ` Daniel Jacobowitz
2007-02-08 21:14         ` Mark Kettenis
2007-02-08 23:00           ` Daniel Jacobowitz
2007-02-14  8:51             ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070213193222.GB32195@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Wiljan.Derks@zonnet.nl \
    --cc=gdb@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox