Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: brobecker@adacore.com, Wiljan.Derks@zonnet.nl, gdb@sourceware.org
Subject: Re: How to tell gdb about dlls using remote protocol
Date: Thu, 08 Feb 2007 23:00:00 -0000	[thread overview]
Message-ID: <20070208230033.GB4258@nevyn.them.org> (raw)
In-Reply-To: <200702082114.l18LEbGk029498@brahms.sibelius.xs4all.nl>

On Thu, Feb 08, 2007 at 10:14:37PM +0100, Mark Kettenis wrote:
> Me neither.  However, Joel's diff has a problem: it makes the
> signull.exp tests fail.  They explicitly test calling a null pointer,
> and that case is now caught by Joel's check.  Skipping a frame in that
> case is not acceptable to me.
> 
> I'm currently testing chaning Joel's original:
> 
>       else if (cache->pc == 0)
> 
> into:
> 
>       else if (cache->pc == 0 && frame_pc_unwind (next_frame) != 0)
> 
> What do you think of that?

Can we actually check for a failure to find the start address?  Using
pc == 0 is unfortunate - we keep encountering people who link code at
zero.

Oh, I guess there's no way; we already use the pc != 0 check in the
same function.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-02-08 23:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 21:08 Wiljan Derks
2007-01-31 22:31 ` Daniel Jacobowitz
2007-02-01 17:52   ` Joel Brobecker
2007-02-01 22:54     ` Daniel Jacobowitz
2007-02-01 23:02       ` Joel Brobecker
2007-02-01 23:59         ` Daniel Jacobowitz
2007-02-02  6:20           ` Robert Dewar
2007-02-02 11:43             ` Daniel Jacobowitz
2007-02-02 16:51               ` Joel Brobecker
2007-02-02 16:56                 ` Daniel Jacobowitz
2007-02-02 17:34                   ` Joel Brobecker
2007-02-05 20:34                     ` Wiljan Derks
2007-02-05 21:21                       ` Joel Brobecker
2007-02-07 21:47                     ` Mark Kettenis
2007-02-07 22:14     ` Mark Kettenis
2007-02-07 22:17       ` Daniel Jacobowitz
2007-02-08 21:14         ` Mark Kettenis
2007-02-08 23:00           ` Daniel Jacobowitz [this message]
2007-02-14  8:51             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208230033.GB4258@nevyn.them.org \
    --to=drow@false.org \
    --cc=Wiljan.Derks@zonnet.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox