From: Daniel Jacobowitz <drow@false.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: mark.kettenis@xs4all.nl, gdb@sources.redhat.com
Subject: Re: core regs vs. proc-service regs mess
Date: Thu, 06 Apr 2006 13:38:00 -0000 [thread overview]
Message-ID: <20060406133250.GA25088@nevyn.them.org> (raw)
In-Reply-To: <20060405.220644.04932953.davem@davemloft.net>
On Wed, Apr 05, 2006 at 10:06:44PM -0700, David S. Miller wrote:
> So something like the following patch? I didn't know what to do with
> the fpxregset stuff, I guess we'll just have to pick some random
> string for that? I couldn't find a ELF section name string assigned
> to that stuff.
It's .reg-xfp; created by bfd/elf.c:elfcore_grok_prxfpreg.
> + if (gdbarch && gdbarch_regset_from_core_section_p (gdbarch)
> + && (regset = gdbarch_regset_from_core_section (gdbarch, ".reg",
> + sizeof gregs)) != NULL)
No point testing gdbarch for NULL; it won't be. Also, I think
gdbarch_regset_from_core_section_p is enough. If that returns NULL,
then skip the regset. We don't need to cater to incomplete
implementations of the core functions.
Oh, and GDB prefers not to use assignments in if statements.
But otherwise, yeah, this is what I had in mind. Thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-06 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 7:07 David S. Miller
2006-04-05 8:25 ` Mark Kettenis
2006-04-05 13:23 ` Daniel Jacobowitz
2006-04-06 1:10 ` David S. Miller
2006-04-06 13:15 ` David S. Miller
2006-04-06 13:38 ` Daniel Jacobowitz [this message]
2006-04-07 0:35 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406133250.GA25088@nevyn.them.org \
--to=drow@false.org \
--cc=davem@davemloft.net \
--cc=gdb@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox