Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: drow@false.org
Cc: mark.kettenis@xs4all.nl, gdb@sources.redhat.com
Subject: Re: core regs vs. proc-service regs mess
Date: Fri, 07 Apr 2006 00:35:00 -0000	[thread overview]
Message-ID: <20060406.135554.14205789.davem@davemloft.net> (raw)
In-Reply-To: <20060406133250.GA25088@nevyn.them.org>

From: Daniel Jacobowitz <drow@false.org>
Date: Thu, 6 Apr 2006 09:32:50 -0400

> It's .reg-xfp; created by bfd/elf.c:elfcore_grok_prxfpreg.
 ...
> No point testing gdbarch for NULL; it won't be.  Also, I think
> gdbarch_regset_from_core_section_p is enough.  If that returns NULL,
> then skip the regset.  We don't need to cater to incomplete
> implementations of the core functions.
> 
> Oh, and GDB prefers not to use assignments in if statements.
> 
> But otherwise, yeah, this is what I had in mind.  Thanks.

Thanks for the feedback.

Can I get approval for the Linux/Sparc dwarf2 bit I posted yesterday?

  http://sources.redhat.com/ml/gdb-patches/2006-04/msg00065.html
 
I want to get that in first, then I'll finish up a final version of
these core regs changes.

Also, I haven't gotten approval for that one-liner break.exp fix
I posted the other day which we discussed in depth a few days
ago:

  http://sources.redhat.com/ml/gdb-patches/2006-04/msg00051.html

If I could get an ACK or NACK on that I'd really appreciate it.

Thanks a lot!


      reply	other threads:[~2006-04-06 20:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-05  7:07 David S. Miller
2006-04-05  8:25 ` Mark Kettenis
2006-04-05 13:23   ` Daniel Jacobowitz
2006-04-06  1:10     ` David S. Miller
2006-04-06 13:15     ` David S. Miller
2006-04-06 13:38       ` Daniel Jacobowitz
2006-04-07  0:35         ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060406.135554.14205789.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox