Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pgilliam@us.ibm.com
Cc: gdb@sources.redhat.com
Subject: Re: What should be used instead of deprecated_read_memory_nobpt()?
Date: Tue, 29 Nov 2005 22:07:00 -0000	[thread overview]
Message-ID: <200511292204.jATM4R1s022362@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <200511291401.30945.pgilliam@us.ibm.com> (message from Paul 	Gilliam on Tue, 29 Nov 2005 14:01:30 -0800)

> From: Paul Gilliam <pgilliam@us.ibm.com>
> Date: Tue, 29 Nov 2005 14:01:30 -0800
> 
> I need to write an implementation of
> 'gdbarch_in_function_epilogue_p()'.  In looking for a model to use,
> I see that 'hppa_in_function_epilogue_p()' and
> 's390_in_function_epilogue_p()' both use
> 'deprecated_read_memory_nobpt()' to get instructions from the
> target, but 'sh_in_function_epilogue_p()' and
> 'xstormy16_in_function_epilogue_p()' both use
> 'read_memory_unsigned_integer()' for that purpose.
> 
> Can 'read_memory_unsigned_integer()' replace 'deprecated_read_memory_nobpt()'?

Not sure, but read_memory_unsigned_integer() might not be safe,
because of the possibility of inserted breakpoints.  The safe
alternative is safe_frame_unwind_memory().  But of course that means
that in_function_epilogue_p should really be changed such that it
accepts a `struct frame *' as an argument.

Mark


  reply	other threads:[~2005-11-29 22:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-29 22:04 Paul Gilliam
2005-11-29 22:07 ` Mark Kettenis [this message]
2005-11-29 22:14   ` Joel Brobecker
2005-11-30  1:36     ` Daniel Jacobowitz
2005-11-30  1:38       ` Jim Blandy
2005-11-30 23:17         ` Paul Gilliam
2005-12-07  2:12           ` Andrew Cagney
2005-11-29 22:15   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511292204.jATM4R1s022362@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb@sources.redhat.com \
    --cc=pgilliam@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox