From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23656 invoked by alias); 29 Nov 2005 22:04:38 -0000 Received: (qmail 23645 invoked by uid 22791); 29 Nov 2005 22:04:37 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Nov 2005 22:04:36 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id jATM4VQe018432; Tue, 29 Nov 2005 23:04:31 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id jATM4VBh004401; Tue, 29 Nov 2005 23:04:31 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id jATM4R1s022362; Tue, 29 Nov 2005 23:04:27 +0100 (CET) Date: Tue, 29 Nov 2005 22:07:00 -0000 Message-Id: <200511292204.jATM4R1s022362@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pgilliam@us.ibm.com CC: gdb@sources.redhat.com In-reply-to: <200511291401.30945.pgilliam@us.ibm.com> (message from Paul Gilliam on Tue, 29 Nov 2005 14:01:30 -0800) Subject: Re: What should be used instead of deprecated_read_memory_nobpt()? References: <200511291401.30945.pgilliam@us.ibm.com> Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00625.txt.bz2 > From: Paul Gilliam > Date: Tue, 29 Nov 2005 14:01:30 -0800 > > I need to write an implementation of > 'gdbarch_in_function_epilogue_p()'. In looking for a model to use, > I see that 'hppa_in_function_epilogue_p()' and > 's390_in_function_epilogue_p()' both use > 'deprecated_read_memory_nobpt()' to get instructions from the > target, but 'sh_in_function_epilogue_p()' and > 'xstormy16_in_function_epilogue_p()' both use > 'read_memory_unsigned_integer()' for that purpose. > > Can 'read_memory_unsigned_integer()' replace 'deprecated_read_memory_nobpt()'? Not sure, but read_memory_unsigned_integer() might not be safe, because of the possibility of inserted breakpoints. The safe alternative is safe_frame_unwind_memory(). But of course that means that in_function_epilogue_p should really be changed such that it accepts a `struct frame *' as an argument. Mark