From: Roland McGrath <roland@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: gdb@sources.redhat.com
Subject: Re: remote protocol support for TARGET_OBJECT_AUXV
Date: Tue, 24 Feb 2004 23:21:00 -0000 [thread overview]
Message-ID: <200402242321.i1ONLTPE001897@magilla.sf.frob.com> (raw)
In-Reply-To: Eli Zaretskii's message of , 12 February 2004 08:27:47 +0200 <uad3oizh8.fsf@elta.co.il>
> I suggest using @var{nn} (lower-case) instead of @var{NN}, since that
> should look better in the printed manual. Also, please explain in
> the text what does @var{nn} stand for; I assume it's a number that
> tells what kind of error happened, but I think the manual shouldn't
> leave that to reader's guesses.
I copied this part of the documentation, and protocol behavior, from the
other existing protocol requests. As far as I can tell, they are all
underspecified. What gdbserver seems to do is actually write "ENN" (two
literal 'N's). So go figure. I'd be happy to change my additions to
reference a standard explanation of what error packets really look like.
But the mess was here before me and I'm not the one who knows how it ought
to be different.
> > +@table @samp
>
> I don't think @samp is appropriate here: it puts every item in
> quotes, which is a bit ugly. Your @item's already have the necessary
> markup (@code etc.), so I'd suggest to use "@table @asis" instead.
Again, just copied another similar place in gdb.texinfo. I'll happily
change this as you say. I think the manual may already be inconsistent
with itself in the formatting style for packet text.
> > +@item @code{E}@var{NN}
> > +The request is bad, the offset is invalid,
> > +or there was an error encountered writing the data.
>
> See the comment above about @var{NN}.
I've change dthese to @code{E}@var{nn} because you said so.
But every other existing appearance is @code{E}@var{NN}, what I copied.
> The empty item is confusing and will look awkward in print, I think.
> How about this instead:
>
> @item @code{""} (empty)
Whatever you say. @code{} was in Andrew's example, so I copied it.
next prev parent reply other threads:[~2004-02-24 23:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <401E5DC0.9020904@gnu.org>
2004-02-04 23:58 ` Roland McGrath
2004-02-05 6:34 ` Eli Zaretskii
2004-02-05 15:54 ` Andrew Cagney
2004-02-06 2:49 ` Roland McGrath
2004-02-06 17:02 ` Andrew Cagney
2004-02-12 2:12 ` Roland McGrath
2004-02-12 6:26 ` Eli Zaretskii
2004-02-24 23:21 ` Roland McGrath [this message]
2004-02-25 5:47 ` Eli Zaretskii
2004-02-25 14:34 ` Daniel Jacobowitz
2004-02-25 15:17 ` Eli Zaretskii
2004-02-25 15:54 ` Andrew Cagney
2004-02-25 16:06 ` Daniel Jacobowitz
2004-02-26 6:14 ` Eli Zaretskii
2004-02-26 14:57 ` Daniel Jacobowitz
2004-02-26 16:57 ` Nathan J. Williams
2004-02-26 18:56 ` Eli Zaretskii
2004-02-12 16:42 ` Andrew Cagney
2004-02-24 23:29 ` Roland McGrath
2004-02-25 5:49 ` Eli Zaretskii
2004-02-25 16:06 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402242321.i1ONLTPE001897@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=eliz@elta.co.il \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox