From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20451 invoked by alias); 24 Feb 2004 23:21:35 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 20439 invoked from network); 24 Feb 2004 23:21:33 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130) by sources.redhat.com with SMTP; 24 Feb 2004 23:21:33 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 7E9F5357B; Tue, 24 Feb 2004 15:21:31 -0800 (PST) Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1]) by magilla.sf.frob.com (8.12.9/8.12.9) with ESMTP id i1ONLVOi001901; Tue, 24 Feb 2004 15:21:31 -0800 Received: (from roland@localhost) by magilla.sf.frob.com (8.12.9/8.12.9/Submit) id i1ONLTPE001897; Tue, 24 Feb 2004 15:21:29 -0800 Date: Tue, 24 Feb 2004 23:21:00 -0000 Message-Id: <200402242321.i1ONLTPE001897@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Eli Zaretskii Cc: gdb@sources.redhat.com Subject: Re: remote protocol support for TARGET_OBJECT_AUXV In-Reply-To: Eli Zaretskii's message of , 12 February 2004 08:27:47 +0200 X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. X-SW-Source: 2004-02/txt/msg00345.txt.bz2 > I suggest using @var{nn} (lower-case) instead of @var{NN}, since that > should look better in the printed manual. Also, please explain in > the text what does @var{nn} stand for; I assume it's a number that > tells what kind of error happened, but I think the manual shouldn't > leave that to reader's guesses. I copied this part of the documentation, and protocol behavior, from the other existing protocol requests. As far as I can tell, they are all underspecified. What gdbserver seems to do is actually write "ENN" (two literal 'N's). So go figure. I'd be happy to change my additions to reference a standard explanation of what error packets really look like. But the mess was here before me and I'm not the one who knows how it ought to be different. > > +@table @samp > > I don't think @samp is appropriate here: it puts every item in > quotes, which is a bit ugly. Your @item's already have the necessary > markup (@code etc.), so I'd suggest to use "@table @asis" instead. Again, just copied another similar place in gdb.texinfo. I'll happily change this as you say. I think the manual may already be inconsistent with itself in the formatting style for packet text. > > +@item @code{E}@var{NN} > > +The request is bad, the offset is invalid, > > +or there was an error encountered writing the data. > > See the comment above about @var{NN}. I've change dthese to @code{E}@var{nn} because you said so. But every other existing appearance is @code{E}@var{NN}, what I copied. > The empty item is confusing and will look awkward in print, I think. > How about this instead: > > @item @code{""} (empty) Whatever you say. @code{} was in Andrew's example, so I copied it.