From: Daniel Jacobowitz <drow@mvista.com>
To: Olaf Hering <olh@suse.de>
Cc: gdb@sources.redhat.com, Will Schmidt <willschm@us.ibm.com>
Subject: Re: remove enum from ppc-linux-tdep.c
Date: Sun, 26 Jan 2003 19:30:00 -0000 [thread overview]
Message-ID: <20030126193104.GA2143@nevyn.them.org> (raw)
In-Reply-To: <20030126192055.GA22537@suse.de>
On Sun, Jan 26, 2003 at 08:20:55PM +0100, Olaf Hering wrote:
> Hi,
>
> this patch uses the defines from asm/elf.h instead of the hardcoded
> values. Would that have any bad side effects? asm-ppc64 includes elf.h
> via sigcontext.h and that will result in a syntax error.
> +#include "<asm/elf.h>"
First of all, that's a syntax error :)
Secondly, tdep stands for target dependant. This needs to work from
any host platform. The right thing to do is probably to rename the
enum: PPC_LINUX_ELF_NGREG, or something like that.
[Or fix your headers. That's pretty bad namespace polution. It
shouldn't do that.]
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-01-26 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-26 19:21 Olaf Hering
2003-01-26 19:30 ` Daniel Jacobowitz [this message]
2003-01-26 19:38 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030126193104.GA2143@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb@sources.redhat.com \
--cc=olh@suse.de \
--cc=willschm@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox