From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6339 invoked by alias); 26 Jan 2003 19:30:44 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6332 invoked from network); 26 Jan 2003 19:30:44 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 26 Jan 2003 19:30:44 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18cuNF-0001cw-00; Sun, 26 Jan 2003 15:31:29 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18csUi-0000ZT-00; Sun, 26 Jan 2003 14:31:04 -0500 Date: Sun, 26 Jan 2003 19:30:00 -0000 From: Daniel Jacobowitz To: Olaf Hering Cc: gdb@sources.redhat.com, Will Schmidt Subject: Re: remove enum from ppc-linux-tdep.c Message-ID: <20030126193104.GA2143@nevyn.them.org> Mail-Followup-To: Olaf Hering , gdb@sources.redhat.com, Will Schmidt References: <20030126192055.GA22537@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030126192055.GA22537@suse.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00421.txt.bz2 On Sun, Jan 26, 2003 at 08:20:55PM +0100, Olaf Hering wrote: > Hi, > > this patch uses the defines from asm/elf.h instead of the hardcoded > values. Would that have any bad side effects? asm-ppc64 includes elf.h > via sigcontext.h and that will result in a syntax error. > +#include "" First of all, that's a syntax error :) Secondly, tdep stands for target dependant. This needs to work from any host platform. The right thing to do is probably to rename the enum: PPC_LINUX_ELF_NGREG, or something like that. [Or fix your headers. That's pretty bad namespace polution. It shouldn't do that.] -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer