Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: carlton@math.stanford.edu, gdb@sources.redhat.com
Cc: drow@mvista.com
Subject: Re: how canonical are template names?
Date: Sat, 11 Jan 2003 00:59:00 -0000	[thread overview]
Message-ID: <200301110059.h0B0xE531597@duracef.shout.net> (raw)

David C writes:
> When I tested the patch, I saw some regressions in
> gdb.c++/templates.exp.  But, on looking at the situation further, I'm
> not sure that they qualify as regressions.

templates.exp has issues.  :(  I'm working on a rewrite but it's on
the back burner right now.  You'll have to hand-analyze the results,
which I see you've done.

In fact, I'd like to just write a brand new templates test file,
include all the useful testing from the old one, and then strangle
the old one.

> Here, the new output switches the 'char' and 'volatile'.  It's still
> the same type.

GDB is okay here.

> type = class Baz<int, 115> {

GDB is incorrect here.  sz is of type 'char' so it should be printed
like that.

* Current:

> type = class Qux<char, &(string)> {

This is probably a judgement call.  My opinion is that it's legal for
gdb to emit this.  It's annoying but we have much worse problems to fix,
so just eat it and go on to the other 570 open PR's.  I would like to
accept the parens for another 3-5 years, and we can revisit them once
gcc 2 is no longer supported, stabs is dead, and so on.

I would file a PR about the '115' that should be a character 's'
and let the others go.  My two cents.

Michael C


             reply	other threads:[~2003-01-11  0:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-11  0:59 Michael Elizabeth Chastain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-01-11  1:07 Michael Elizabeth Chastain
2003-01-11  3:42 ` Daniel Jacobowitz
2003-01-10 21:42 David Carlton
2003-01-10 21:55 ` Daniel Jacobowitz
2003-01-10 22:44   ` David Carlton
2003-01-10 23:34 ` Stan Shebs
2003-01-10 23:47   ` David Carlton
2003-01-10 21:19 David Carlton
2003-01-10 21:21 ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200301110059.h0B0xE531597@duracef.shout.net \
    --to=mec@shout.net \
    --cc=carlton@math.stanford.edu \
    --cc=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox