Re: [patch] remove Tix

Re: [patch] remove Tix

[Nick Kelsey]

Hi Andrew,

> If tix was removed, someone checking out:
> -D last-year insight
> would find that the no longer got tix (which was needed back then).

I am all for removing redundant code.

If tix isn't needed then marking it as deleted in CVS shouldn't affect
someone checking out an earlier version - they would still get tix as long
as it was before the delete date.

I have to admit that I usually use CVS through a GUI so I would need to look
up the procedure but deleting files works fine just as long as you get CVS
to do it and don't manually delete the files on the server.

Nick

> *This message was transferred with a trial version of CommuniGate(tm) Pro*
> > On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
> >
> >>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
> >>
> >> * generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
> >> Don't include tix.h
> >>
> >> * generic/gdbtk-hooks.c: Don't include tix.h.
> >>
> >> * generic/gdbtkj-cmds.c: Don't include tix.h.
> >
> >
> > Does this mean that we can remove tix from the insight module
> > on sources dot redhat dot com?
>
> Not really.
>
> If tix was removed, someone checking out:
> -D last-year insight
> would find that the no longer got tix (which was needed back then).
>
> Might end up doing something like adding a module:
> insight-5-3
>
> Andrew
>
>
>

Re: [patch] remove Tix

[Christopher Faylor]

On Thu, Nov 28, 2002 at 07:59:00PM -0800, Nick Kelsey wrote:
>>If tix was removed, someone checking out: -D last-year insight would
>>find that the no longer got tix (which was needed back then).
>
>I am all for removing redundant code.
>
>If tix isn't needed then marking it as deleted in CVS shouldn't affect
>someone checking out an earlier version - they would still get tix as
>long as it was before the delete date.

I was talking about removing tix from the gdb module, not "cvs
remove"ing it (although that's an option, too).  Removing it from the
module will have the effect that Andrew describes since this just
involves editing the modules file in CVSROOT.  Personally, I don't think
it is a big deal.

You either confuse every future person who wonders why they're getting
the tix directory when they don't need it or you insure that those rare
individuals who 'cvs checkout' past versions of insight will not be
bothered by the lack of tix.

Hmm.  Sounds like tix can be removed from the top level Makefiles, too.

cgf

Re: [patch] remove Tix

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Nick,

This discussion belongs on the insight@ mailing list.

Andrew

[-- Attachment #2: mailbox-message://ac131313@movemail/fsf/gdb/misc#3704597 --]
[-- Type: message/rfc822, Size: 3231 bytes --]

From: "Nick Kelsey" <nickk@ubicom.com>
To: "Andrew Cagney" <ac131313@redhat.com>
Cc: <gdb@sources.redhat.com>
Subject: Re: [patch] remove Tix
Date: Thu, 28 Nov 2002 19:59:00 -0800
Message-ID: <006001c2975b$a6fdbc60$0a00a8c0@nkelseyhome>

Hi Andrew,

> If tix was removed, someone checking out:
> -D last-year insight
> would find that the no longer got tix (which was needed back then).

I am all for removing redundant code.

If tix isn't needed then marking it as deleted in CVS shouldn't affect
someone checking out an earlier version - they would still get tix as long
as it was before the delete date.

I have to admit that I usually use CVS through a GUI so I would need to look
up the procedure but deleting files works fine just as long as you get CVS
to do it and don't manually delete the files on the server.

Nick

> *This message was transferred with a trial version of CommuniGate(tm) Pro*
> > On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
> >
> >>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
> >>
> >> * generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
> >> Don't include tix.h
> >>
> >> * generic/gdbtk-hooks.c: Don't include tix.h.
> >>
> >> * generic/gdbtkj-cmds.c: Don't include tix.h.
> >
> >
> > Does this mean that we can remove tix from the insight module
> > on sources dot redhat dot com?
>
> Not really.
>
> If tix was removed, someone checking out:
> -D last-year insight
> would find that the no longer got tix (which was needed back then).
>
> Might end up doing something like adding a module:
> insight-5-3
>
> Andrew
>
>
>