Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: "Kris Warkentin" <kewarken@qnx.com>
Cc: Richard.Earnshaw@arm.com, gdb@sources.redhat.com
Subject: Re: ARM stack alignment on hand called functions
Date: Thu, 21 Nov 2002 02:58:00 -0000	[thread overview]
Message-ID: <200211211058.gALAwAB03462@pc960.cambridge.arm.com> (raw)
In-Reply-To: Your message of "Wed, 20 Nov 2002 14:40:18 EST." <1a2a01c290cc$aa02bef0$0202040a@catdog>

> > > OK, but with this change the alignment is being done *after* any
> arguments
> > > that have to go onto the stack have been pushed.  It should happen
> > > *before*.  What happens if you have?
> 
> You're right.  If I put the "sp = (sp + 3) & ~3" at the top of
> arm_push_arguments(), everything works.  I see that a lot of stuff in
> arm-tdep.c has been changed extensively on your head branch, including
> arm_push_arguments().  Probably once we move to the head branch, everything
> will work fine.
> 

Don't forget that the stack is a "full-descending" stack; so you should be 
rounding the value down, not up.

R.


  reply	other threads:[~2002-11-21 10:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-20  7:29 Kris Warkentin
2002-11-20  7:58 ` Richard Earnshaw
2002-11-20  8:10   ` Kris Warkentin
2002-11-20  8:21     ` Richard Earnshaw
2002-11-20  8:26       ` Kris Warkentin
2002-11-20  9:18         ` Andrew Cagney
2002-11-20  9:35           ` Kris Warkentin
2002-11-26 14:01             ` Andrew Cagney
2002-11-27  1:18               ` Richard Earnshaw
2002-11-20 10:37         ` Richard Earnshaw
2002-11-20 10:59           ` Kris Warkentin
2002-11-20 11:40             ` Kris Warkentin
2002-11-21  2:58               ` Richard Earnshaw [this message]
     [not found] <200211272021.PAA04606@hub.ott.qnx.com>
2002-11-27 13:13 ` Kris Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211211058.gALAwAB03462@pc960.cambridge.arm.com \
    --to=rearnsha@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb@sources.redhat.com \
    --cc=kewarken@qnx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox