From: Richard Henderson <rth@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org, gdb@sources.redhat.com
Subject: Re: [patch] generic simd support
Date: Thu, 30 May 2002 15:42:00 -0000 [thread overview]
Message-ID: <20020530154256.F5362@redhat.com> (raw)
In-Reply-To: <20020522004429.GA26426@redhat.com>; from aldyh@redhat.com on Wed, May 22, 2002 at 10:44:29AM +1000
On Wed, May 22, 2002 at 10:44:29AM +1000, Aldy Hernandez wrote:
> ! error ("architecture does not support `%s' and I am unable to emulate it",
Better just "unable to emulate %s".
> + /* Open-code the vector operations if we have no hardware support
> + for them. */
This function is way too big already. Please move your code
out into a subroutine.
> ! /* ?? I'm not sure whether this is right. This is the path we
> ! take on synthetic complex types because the target is a
> ! CONCAT of register, not a register per se. However, for
> ! synthetic vector types, we don't have a CONCAT, but an
> ! entire pseudo. Get out here to avoid removing needed
> ! instructions.
> ! ?? */
> ! || vector_mode_valid_p (GET_MODE (target))
> ! || reload_in_progress)
Maybe you should just avoid the no-conflict block entirely?
Otherwise it looks reasonable.
r~
next prev parent reply other threads:[~2002-05-30 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-21 17:45 Aldy Hernandez
2002-05-22 14:09 ` Daniel Egger
2002-05-30 15:42 ` Richard Henderson [this message]
2002-06-16 2:10 ` Aldy Hernandez
2002-06-16 10:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020530154256.F5362@redhat.com \
--to=rth@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox