From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13631 invoked by alias); 30 May 2002 22:42:58 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 13612 invoked from network); 30 May 2002 22:42:57 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 30 May 2002 22:42:57 -0000 Received: from dot.sfbay.redhat.com (dot.sfbay.redhat.com [172.16.24.7]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g4UMetv31240; Thu, 30 May 2002 15:40:55 -0700 Received: (from rth@localhost) by dot.sfbay.redhat.com (8.11.6/8.11.6) id g4UMguS05473; Thu, 30 May 2002 15:42:56 -0700 X-Authentication-Warning: dot.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Thu, 30 May 2002 15:42:00 -0000 From: Richard Henderson To: Aldy Hernandez Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org, gdb@sources.redhat.com Subject: Re: [patch] generic simd support Message-ID: <20020530154256.F5362@redhat.com> Mail-Followup-To: Richard Henderson , Aldy Hernandez , gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org, gdb@sources.redhat.com References: <20020522004429.GA26426@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020522004429.GA26426@redhat.com>; from aldyh@redhat.com on Wed, May 22, 2002 at 10:44:29AM +1000 X-SW-Source: 2002-05/txt/msg00331.txt.bz2 On Wed, May 22, 2002 at 10:44:29AM +1000, Aldy Hernandez wrote: > ! error ("architecture does not support `%s' and I am unable to emulate it", Better just "unable to emulate %s". > + /* Open-code the vector operations if we have no hardware support > + for them. */ This function is way too big already. Please move your code out into a subroutine. > ! /* ?? I'm not sure whether this is right. This is the path we > ! take on synthetic complex types because the target is a > ! CONCAT of register, not a register per se. However, for > ! synthetic vector types, we don't have a CONCAT, but an > ! entire pseudo. Get out here to avoid removing needed > ! instructions. > ! ?? */ > ! || vector_mode_valid_p (GET_MODE (target)) > ! || reload_in_progress) Maybe you should just avoid the no-conflict block entirely? Otherwise it looks reasonable. r~