From: "Martin M. Hunt" <hunt@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>, gdb@sources.redhat.com
Cc: cagney@redhat.com
Subject: Re: Alpha completely broken: build_regcache never called
Date: Wed, 03 Apr 2002 15:23:00 -0000 [thread overview]
Message-ID: <200204032322.g33NMse03622@localhost.localdomain> (raw)
In-Reply-To: <20020403180530.A570@nevyn.them.org>
On Wednesday 03 April 2002 03:05 pm, Daniel Jacobowitz wrote:
> I believe this patch is responsible:
>
> 2002-03-20 Martin M. Hunt <hunt@redhat.com>
>
> * regcache.c (_initialize_regcache): No need to call
> build_regcache() at this time; it gets called whenever
> the gdbarch changes.
>
> Alpha is completely non-multi-arch. Thus the gdbarch appears to never
> change, and we crash very quickly.
Seems like we should just ifdef the call to build_regcache back in.
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.33
diff -u -p -r1.33 regcache.c
--- regcache.c 2002/03/21 02:13:05 1.33
+++ regcache.c 2002/04/03 23:18:15
@@ -802,6 +802,10 @@ build_regcache (void)
void
_initialize_regcache (void)
{
+#if !GDB_MULTI_ARCH
+ build_regcache();
+#endif
+
register_gdbarch_swap (®isters, sizeof (registers), NULL);
register_gdbarch_swap (®ister_valid, sizeof (register_valid), NULL);
register_gdbarch_swap (NULL, 0, build_regcache);
next prev parent reply other threads:[~2002-04-03 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-03 15:05 Daniel Jacobowitz
2002-04-03 15:23 ` Martin M. Hunt [this message]
2002-04-03 21:15 ` Andrew Cagney
2002-04-03 21:25 ` Daniel Jacobowitz
2002-04-04 6:23 ` Andrew Cagney
2002-04-04 8:42 ` Daniel Jacobowitz
2002-04-05 18:30 ` Andrew Cagney
2002-04-05 18:39 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200204032322.g33NMse03622@localhost.localdomain \
--to=hunt@redhat.com \
--cc=cagney@redhat.com \
--cc=drow@mvista.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox