The canadian cross build is broken

The canadian cross build is broken

[H . J . Lu]

The current tree is broken when configured with

# ../configure --host=cpu1-linux --build=i386-linux --target=cpu1-linux

See

http://sources.redhat.com/ml/binutils/2002-02/msg00120.html

I have been using

http://sources.redhat.com/ml/binutils/2002-02/msg00169.html

I guess no one cares about it.


H.J.

Re: The canadian cross build is broken

[Andrew Cagney]

> The current tree is broken when configured with
> 
> # ../configure --host=cpu1-linux --build=i386-linux --target=cpu1-linux
> 
> See
> 
> http://sources.redhat.com/ml/binutils/2002-02/msg00120.html
> 
> I have been using
> 
> http://sources.redhat.com/ml/binutils/2002-02/msg00169.html
> 
> I guess no one cares about it.

I note you CC:'d GCC but To:'d GDB.  Remember, GCC is the supplier here. 
  Both GDB and BINUTILS are users.

The most useful thing to do would be to explain to the above person that 
their patch should be submitted to gcc-patches@.

enjoy,
Andrew

Re: The canadian cross build is broken

[H . J . Lu]

On Sat, Mar 23, 2002 at 10:28:58AM -0500, Andrew Cagney wrote:
> > The current tree is broken when configured with
> > 
> > # ../configure --host=cpu1-linux --build=i386-linux --target=cpu1-linux
> > 
> > See
> > 
> > http://sources.redhat.com/ml/binutils/2002-02/msg00120.html
> > 
> > I have been using
> > 
> > http://sources.redhat.com/ml/binutils/2002-02/msg00169.html
> > 
> > I guess no one cares about it.
> 
> I note you CC:'d GCC but To:'d GDB.  Remember, GCC is the supplier here. 
>   Both GDB and BINUTILS are users.
> 
> The most useful thing to do would be to explain to the above person that 
> their patch should be submitted to gcc-patches@.
> 

I did. You can follow

http://sources.redhat.com/ml/binutils/2002-02/msg00120.html

to see it. DJ believed my patch was wrong, but didn't provide a working
solution. So far, only 2 people complained. We need more people to tell
DJ to get it fixed. Maybe I should give up since my gcc, gdb and
binutils don't have this problem.


H.J.

Re: The canadian cross build is broken

[DJ Delorie]

> I did. You can follow
> 
> http://sources.redhat.com/ml/binutils/2002-02/msg00120.html
> 
> to see it. DJ believed my patch was wrong, but didn't provide a working
> solution.

The problem is that --with-target-subdir invokes some behaviors that
aren't appropriate for a build-libiberty, mostly pertaining to
multilibs.  You yourself weren't sure of your patch:

 "The following hack seems to work, but I'm not convinced it's the
  right fix."

> So far, only 2 people complained.

The number of people complaining usually has nothing to do with the
severity of a bug or the correctness of its solution.  Plus, we do
canadians inside Red Hat all the time and nobody's complained to me
internally.  This doesn't mean it's not a problem, it just means it's
not an "obviously broken" type of problem.  There is a trivial
workaround (which is why RH doesn't see it): don't build in the source
directory.

Perhaps we should disable building in the source directory if it's not
a simple native?  It would simplify some things and make maintaining
it easier.  But that depends on how much more effort is needed to get
the current solution working right.

> We need more people to tell DJ to get it fixed.

Sorry, this won't work.  I'm a volunteer, just like you.  Maybe we
need more people to tell *you* to submit a correct solution?  However,
I appreciate the reminder (even a mildly insulting one) as I do have
this on my todo list, and might have time to actually *look at* my
todo list this week ;)

> Maybe I should give up since my gcc, gdb and binutils don't have
> this problem.

You may do whatever you wish in your own sources, and we certainly
can't force you to contribute back to the official sources.

Re: The canadian cross build is broken

[DJ Delorie]

> > > http://sources.redhat.com/ml/binutils/2002-02/msg00169.html

This is wrong:

+  if [ "${with_build_subdir}" != "." ] || [ "${with_target_subdir}" != "." ]; then

One of them will *always* be ""

You also never followed up on this:

http://sources.redhat.com/ml/binutils/2002-02/msg00172.html

Re: The canadian cross build is broken

[H . J . Lu]

On Mon, Mar 25, 2002 at 05:14:52PM -0500, DJ Delorie wrote:
> 
> > > > http://sources.redhat.com/ml/binutils/2002-02/msg00169.html
> 
> This is wrong:
> 
> +  if [ "${with_build_subdir}" != "." ] || [ "${with_target_subdir}" != "." ]; then
> 
> One of them will *always* be ""
> 

How about this one?


H.J.
----
2002-03-26  H.J. Lu  (hjl@gnu.org)

	* config.table: Support --with-build-subdir.
	* configure.in: Likewise.
	* configure: Rebuild.

--- binutils-2.12.90.0.3/libiberty/config.table.build	Fri Nov 16 14:05:55 2001
+++ binutils-2.12.90.0.3/libiberty/config.table	Tue Mar 26 12:54:58 2002
@@ -1,3 +1,9 @@
+# Don't build the shared library for build.
+if [ -n "${with_build_subdir}" ]; then
+  enable_shared=no
+fi
+
+frag=
 case "${host}" in
   rs6000-ibm-aix3.1 | rs6000-ibm-aix)
                         frag=mh-aix ;;
@@ -8,7 +14,11 @@ case "${host}" in
   i[345]86-*-windows*)	frag=mh-windows ;;
 esac
 
-frags=$frag
+if [ -n "${frag}" ]; then
+  frags=${libiberty_topdir}/libiberty/config/$frag
+else
+  frags=
+fi
 
 # If they didn't specify --enable-shared, don't generate shared libs.
 case "${enable_shared}" in
@@ -20,30 +30,22 @@ esac
 if [ "${shared}" = "yes" ]; then
   case "${host}" in
     *-*-cygwin*)	;;
-    alpha*-*-linux*)	frags="${frags} ../../config/mh-elfalphapic" ;;
-    arm*-*-*)		frags="${frags} ../../config/mh-armpic" ;;
-    hppa*-*-*)		frags="${frags} ../../config/mh-papic" ;;
-    i[3456]86-*-*)	frags="${frags} ../../config/mh-x86pic" ;;
-    mips*-*-linux*)	frags="${frags} ../../config/mh-mipspic" ;;
+    alpha*-*-linux*)	frag=mh-elfalphapic ;;
+    arm*-*-*)		frag=mh-armpic ;;
+    hppa*-*-*)		frag=mh-papic ;;
+    i[3456]86-*-*)	frag=mh-x86pic ;;
+    mips*-*-linux*)	frag=mh-mipspic ;;
     powerpc*-*-aix*)	;;
-    powerpc*-*-*)	frags="${frags} ../../config/mh-ppcpic" ;;
-    sparc*-*-*)		frags="${frags} ../../config/mh-sparcpic" ;;
-    *-*-*)		frags="${frags} ../../config/mh-${host_cpu}pic" ;;
+    powerpc*-*-*)	frag=mh-ppcpic ;;
+    sparc*-*-*)		frag=mh-sparcpic ;;
+    *)			frag=mh-${host_cpu}pic ;;
   esac
+  frags="${frags} ${libiberty_topdir}/config/${frag}"
 fi
 
 echo "# Warning: this fragment is automatically generated" > temp-frag
 
 for frag in ${frags}; do
-  case ${frag} in
-    ../* )
-      if [ ${srcdir} = . ]; then
-	[ -n "${with_target_subdir}" ] && frag=../${frag}
-	[ -n "${with_multisrctop}" ] && frag=${with_multisrctop}${frag}
-      fi
-      ;;
-  esac
-  frag=${srcdir}/${xsrcdir}config/$frag
   if [ -f ${frag} ]; then
     echo "Appending ${frag} to xhost-mkfrag"
     echo "# Following fragment copied from ${frag}" >> temp-frag
--- binutils-2.12.90.0.3/libiberty/configure.in.build	Thu Mar  7 11:52:40 2002
+++ binutils-2.12.90.0.3/libiberty/configure.in	Tue Mar 26 13:04:14 2002
@@ -5,14 +5,19 @@ AC_INIT(pexecute.c)
 
 dnl We use these options to decide which functions to include.
 AC_ARG_WITH(target-subdir,
-[  --with-target-subdir=SUBDIR      Configuring in a subdirectory])
+[  --with-target-subdir=SUBDIR      Configuring in a subdirectory for target])
+AC_ARG_WITH(build-subdir,
+[  --with-build-subdir=SUBDIR       Configuring in a subdirectory for build])
 AC_ARG_WITH(cross-host,
 [  --with-cross-host=HOST           Configuring with a cross compiler])
 AC_ARG_WITH(newlib,
 [  --with-newlib                    Configuring with newlib])
 
 if test "${srcdir}" = "."; then
-  if test -z "${with_target_subdir}"; then
+  if test -n "${with_build_subdir}"; then
+    libiberty_topdir="${srcdir}/../.."
+    with_target_subdir=
+  elif test -z "${with_target_subdir}"; then
     libiberty_topdir="${srcdir}/.."
   else
     if test "${with_target_subdir}" != "."; then
@@ -429,7 +434,7 @@ AC_SUBST(INSTALL_DEST)
 AC_OUTPUT(Makefile testsuite/Makefile,
 [test -z "$CONFIG_HEADERS" || echo timestamp > stamp-h
 if test -n "$CONFIG_FILES"; then
-  if test -n "${with_target_subdir}"; then
+  if test -n "${with_build_subdir}" || test -n "${with_target_subdir}"; then
     # FIXME: We shouldn't need to set ac_file
     ac_file=Makefile
     . ${libiberty_topdir}/config-ml.in

Re: The canadian cross build is broken

[DJ Delorie]

> How about this one?

The configure.in changes look ok, but...

> 	* config.table: Support --with-build-subdir.

Why are we throwing away the ability to have multiple host frags?  Of
course, that whole config.table file looks a bit convoluted.

Re: The canadian cross build is broken

[H . J . Lu]

On Tue, Mar 26, 2002 at 04:35:34PM -0500, DJ Delorie wrote:
> 
> > How about this one?
> 
> The configure.in changes look ok, but...
> 
> > 	* config.table: Support --with-build-subdir.
> 
> Why are we throwing away the ability to have multiple host frags?  Of
> course, that whole config.table file looks a bit convoluted.

What multiple host frags? I am not sure what you meant by that. The
only thing I change is to use ${libiberty_topdir} to locate the host
frags instead the current convoluted way. Do you have an example?


H.J.

Re: The canadian cross build is broken

[DJ Delorie]

> What multiple host frags? I am not sure what you meant by that.

Oops, nevermind.  I see where you moved that logic to.  You need to
check for $frag being empty before adding it to $frags though.

Re: The canadian cross build is broken

[H . J . Lu]

On Tue, Mar 26, 2002 at 04:49:18PM -0500, DJ Delorie wrote:
> 
> > What multiple host frags? I am not sure what you meant by that.
> 
> Oops, nevermind.  I see where you moved that logic to.  You need to
> check for $frag being empty before adding it to $frags though.

Why? Here is the fragment. $frag won't be empty. The default one is
mh-${host_cpu}pic:

if [ "${shared}" = "yes" ]; then
  case "${host}" in
    *-*-cygwin*)        ;;
    alpha*-*-linux*)    frag=mh-elfalphapic ;;
    arm*-*-*)           frag=mh-armpic ;;
    hppa*-*-*)          frag=mh-papic ;;
    i[3456]86-*-*)      frag=mh-x86pic ;;
    mips*-*-linux*)     frag=mh-mipspic ;;
    powerpc*-*-aix*)    ;;
    powerpc*-*-*)       frag=mh-ppcpic ;;
    sparc*-*-*)         frag=mh-sparcpic ;;
    *)                  frag=mh-${host_cpu}pic ;;
  esac
  frags="${frags} ${libiberty_topdir}/config/${frag}"
fi

Later, we check if it exists:

for frag in ${frags}; do
  if [ -f ${frag} ]; then
    echo "Appending ${frag} to xhost-mkfrag"
    echo "# Following fragment copied from ${frag}" >> temp-frag
    cat ${frag} >> temp-frag
  fi
done

before appending it. Did I miss something?



H.J.

H.J.

Re: The canadian cross build is broken

[DJ Delorie]

> Why? Here is the fragment. $frag won't be empty. The default one is
> mh-${host_cpu}pic:

In some future cases, it may end up getting added twice, in other
cases, it's empty and may cause problems.  For example, for cygwin
frag remains set to its previous value (currently empty) so you end up
adding "config/" to the list of frags.

> if [ "${shared}" = "yes" ]; then
>   case "${host}" in
>     *-*-cygwin*)        ;;

> Later, we check if it exists:
> 
> for frag in ${frags}; do
>   if [ -f ${frag} ]; then
>     echo "Appending ${frag} to xhost-mkfrag"
>     echo "# Following fragment copied from ${frag}" >> temp-frag
>     cat ${frag} >> temp-frag
>   fi
> done
> 
> before appending it. Did I miss something?

Some broken OSs may treat directories as meeting "test -f" :-(

Re: The canadian cross build is broken

[H . J . Lu]

On Tue, Mar 26, 2002 at 05:00:27PM -0500, DJ Delorie wrote:
> 
> > Why? Here is the fragment. $frag won't be empty. The default one is
> > mh-${host_cpu}pic:
> 
> In some future cases, it may end up getting added twice, in other
> cases, it's empty and may cause problems.  For example, for cygwin
> frag remains set to its previous value (currently empty) so you end up
> adding "config/" to the list of frags.

A new patch. I put back

+with_build_subdir=${with_build_subdir}

into configure.in. Otherwise, ${libiberty_topdir}/config-ml.in won't
be called.


H.J.
---
2002-03-26  H.J. Lu  (hjl@gnu.org)

	* config.table: Support --with-build-subdir.
	* configure.in: Likewise.
	* configure: Rebuild.

--- binutils-2.12.90.0.3/libiberty/config.table.build	Fri Nov 16 14:05:55 2001
+++ binutils-2.12.90.0.3/libiberty/config.table	Tue Mar 26 14:02:46 2002
@@ -1,3 +1,9 @@
+# Don't build the shared library for build.
+if [ -n "${with_build_subdir}" ]; then
+  enable_shared=no
+fi
+
+frag=
 case "${host}" in
   rs6000-ibm-aix3.1 | rs6000-ibm-aix)
                         frag=mh-aix ;;
@@ -8,7 +14,11 @@ case "${host}" in
   i[345]86-*-windows*)	frag=mh-windows ;;
 esac
 
-frags=$frag
+if [ -n "${frag}" ]; then
+  frags=${libiberty_topdir}/libiberty/config/$frag
+else
+  frags=
+fi
 
 # If they didn't specify --enable-shared, don't generate shared libs.
 case "${enable_shared}" in
@@ -18,32 +28,27 @@ case "${enable_shared}" in
   *) shared=yes ;;
 esac
 if [ "${shared}" = "yes" ]; then
+  frag=
   case "${host}" in
     *-*-cygwin*)	;;
-    alpha*-*-linux*)	frags="${frags} ../../config/mh-elfalphapic" ;;
-    arm*-*-*)		frags="${frags} ../../config/mh-armpic" ;;
-    hppa*-*-*)		frags="${frags} ../../config/mh-papic" ;;
-    i[3456]86-*-*)	frags="${frags} ../../config/mh-x86pic" ;;
-    mips*-*-linux*)	frags="${frags} ../../config/mh-mipspic" ;;
+    alpha*-*-linux*)	frag=mh-elfalphapic ;;
+    arm*-*-*)		frag=mh-armpic ;;
+    hppa*-*-*)		frag=mh-papic ;;
+    i[3456]86-*-*)	frag=mh-x86pic ;;
+    mips*-*-linux*)	frag=mh-mipspic ;;
     powerpc*-*-aix*)	;;
-    powerpc*-*-*)	frags="${frags} ../../config/mh-ppcpic" ;;
-    sparc*-*-*)		frags="${frags} ../../config/mh-sparcpic" ;;
-    *-*-*)		frags="${frags} ../../config/mh-${host_cpu}pic" ;;
+    powerpc*-*-*)	frag=mh-ppcpic ;;
+    sparc*-*-*)		frag=mh-sparcpic ;;
+    *)			frag=mh-${host_cpu}pic ;;
   esac
+  if [ -n "${frag}" ]; then
+    frags="${frags} ${libiberty_topdir}/config/${frag}"
+  fi
 fi
 
 echo "# Warning: this fragment is automatically generated" > temp-frag
 
 for frag in ${frags}; do
-  case ${frag} in
-    ../* )
-      if [ ${srcdir} = . ]; then
-	[ -n "${with_target_subdir}" ] && frag=../${frag}
-	[ -n "${with_multisrctop}" ] && frag=${with_multisrctop}${frag}
-      fi
-      ;;
-  esac
-  frag=${srcdir}/${xsrcdir}config/$frag
   if [ -f ${frag} ]; then
     echo "Appending ${frag} to xhost-mkfrag"
     echo "# Following fragment copied from ${frag}" >> temp-frag
--- binutils-2.12.90.0.3/libiberty/configure.in.build	Thu Mar  7 11:52:40 2002
+++ binutils-2.12.90.0.3/libiberty/configure.in	Tue Mar 26 14:32:11 2002
@@ -5,14 +5,19 @@ AC_INIT(pexecute.c)
 
 dnl We use these options to decide which functions to include.
 AC_ARG_WITH(target-subdir,
-[  --with-target-subdir=SUBDIR      Configuring in a subdirectory])
+[  --with-target-subdir=SUBDIR      Configuring in a subdirectory for target])
+AC_ARG_WITH(build-subdir,
+[  --with-build-subdir=SUBDIR       Configuring in a subdirectory for build])
 AC_ARG_WITH(cross-host,
 [  --with-cross-host=HOST           Configuring with a cross compiler])
 AC_ARG_WITH(newlib,
 [  --with-newlib                    Configuring with newlib])
 
 if test "${srcdir}" = "."; then
-  if test -z "${with_target_subdir}"; then
+  if test -n "${with_build_subdir}"; then
+    libiberty_topdir="${srcdir}/../.."
+    with_target_subdir=
+  elif test -z "${with_target_subdir}"; then
     libiberty_topdir="${srcdir}/.."
   else
     if test "${with_target_subdir}" != "."; then
@@ -429,7 +434,7 @@ AC_SUBST(INSTALL_DEST)
 AC_OUTPUT(Makefile testsuite/Makefile,
 [test -z "$CONFIG_HEADERS" || echo timestamp > stamp-h
 if test -n "$CONFIG_FILES"; then
-  if test -n "${with_target_subdir}"; then
+  if test -n "${with_build_subdir}" || test -n "${with_target_subdir}"; then
     # FIXME: We shouldn't need to set ac_file
     ac_file=Makefile
     . ${libiberty_topdir}/config-ml.in
@@ -439,6 +444,7 @@ srcdir=${srcdir}
 host=${host}
 target=${target}
 with_target_subdir=${with_target_subdir}
+with_build_subdir=${with_build_subdir}
 with_multisubdir=${with_multisubdir}
 ac_configure_args="--enable-multilib ${ac_configure_args}"
 CONFIG_SHELL=${CONFIG_SHELL-/bin/sh}

Re: The canadian cross build is broken

[DJ Delorie]

> A new patch. I put back
> 
> +with_build_subdir=${with_build_subdir}
> 
> into configure.in. Otherwise, ${libiberty_topdir}/config-ml.in won't
> be called.
> 
> 
> H.J.
> ---
> 2002-03-26  H.J. Lu  (hjl@gnu.org)
> 
> 	* config.table: Support --with-build-subdir.
> 	* configure.in: Likewise.
> 	* configure: Rebuild.

This version is approved.  Thanks!
(now let's all cross our fingers... ;)

Re: The canadian cross build is broken

[H . J . Lu]

On Tue, Mar 26, 2002 at 05:49:14PM -0500, DJ Delorie wrote:
> 
> > A new patch. I put back
> > 
> > +with_build_subdir=${with_build_subdir}
> > 
> > into configure.in. Otherwise, ${libiberty_topdir}/config-ml.in won't
> > be called.
> > 
> > 
> > H.J.
> > ---
> > 2002-03-26  H.J. Lu  (hjl@gnu.org)
> > 
> > 	* config.table: Support --with-build-subdir.
> > 	* configure.in: Likewise.
> > 	* configure: Rebuild.
> 
> This version is approved.  Thanks!
> (now let's all cross our fingers... ;)

Done. When should I expect it to show up in src?

Thanks.


H.J.

Re: The canadian cross build is broken

[DJ Delorie]

> Done. When should I expect it to show up in src?

It's there.  It would have been sooner, but I was eating supper.