Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Jason Merrill <jason@redhat.com>
Cc: libstdc++@gcc.gnu.org, gdb@sources.redhat.com
Subject: Re: C++ debugging progress
Date: Wed, 21 Nov 2001 13:42:00 -0000	[thread overview]
Message-ID: <20011128153226.A1557@nevyn.them.org> (raw)
In-Reply-To: <wvly9kqy98q.fsf@prospero.cambridge.redhat.com>

On Wed, Nov 28, 2001 at 07:40:37PM +0000, Jason Merrill wrote:
> >>>>> "Daniel" == Daniel Jacobowitz <drow@mvista.com> writes:
> 
> > On Wed, Nov 28, 2001 at 09:31:07AM +0000, Jason Merrill wrote:
> 
> >> So you're using the inheritance information in the RTTI rather than the debug
> >> info?  That seems unfortunate.  I'm not sure why you would need to worry
> >> about ordering; the debug info should tell you exactly where things are.
> >> If it doesn't, it should probably be fixed.
> 
> > In that case, the debug info absolutely needs to be fixed.
> 
> >  <1><22e>: Abbrev Number: 15 (DW_TAG_structure_type)
> >      DW_AT_sibling     : <2df>  
> >      DW_AT_name        : Left   
> >      DW_AT_byte_size   : 12     
> >      DW_AT_decl_file   : 1      
> >      DW_AT_decl_line   : 2      
> >      DW_AT_containing_type: <22e>       
> >  <2><23f>: Abbrev Number: 22 (DW_TAG_inheritance)
> >      DW_AT_type        : <56>   
> >      DW_AT_data_member_location: 2 byte block: 23 8 (DW_OP_plus_uconst: 8; )
> >      DW_AT_virtuality  : 1      (virtual)
> >      DW_AT_accessibility: 1     (public)
> 
> Yep.  Since Base is a virtual base of Left, the DW_AT_data_member_location
> here should be a complex expression telling the debugger to go through the
> vtable.  I'll get on it.
> 
> I'll also change the stabs output to give the offset within the vtable
> rather than the offset of the base in a complete object; gdb will still
> need to be clever enough to know what to do with it.

I should add: is there some way we can disambiguate correct and
incorrect debug info after this fix?  For Dwarf2 I see how to do it
pretty easily.  Would an explicit minus sign work?  I think GDB won't
croak on that.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@mvista.com>
To: Jason Merrill <jason@redhat.com>
Cc: libstdc++@gcc.gnu.org, gdb@sources.redhat.com
Subject: Re: C++ debugging progress
Date: Wed, 28 Nov 2001 12:32:00 -0000	[thread overview]
Message-ID: <20011128153226.A1557@nevyn.them.org> (raw)
Message-ID: <20011128123200.IivhxBt-5a1J6JHnU7JDxV4Fl64y92JHN04RC8qpe7g@z> (raw)
In-Reply-To: <wvly9kqy98q.fsf@prospero.cambridge.redhat.com>

On Wed, Nov 28, 2001 at 07:40:37PM +0000, Jason Merrill wrote:
> >>>>> "Daniel" == Daniel Jacobowitz <drow@mvista.com> writes:
> 
> > On Wed, Nov 28, 2001 at 09:31:07AM +0000, Jason Merrill wrote:
> 
> >> So you're using the inheritance information in the RTTI rather than the debug
> >> info?  That seems unfortunate.  I'm not sure why you would need to worry
> >> about ordering; the debug info should tell you exactly where things are.
> >> If it doesn't, it should probably be fixed.
> 
> > In that case, the debug info absolutely needs to be fixed.
> 
> >  <1><22e>: Abbrev Number: 15 (DW_TAG_structure_type)
> >      DW_AT_sibling     : <2df>  
> >      DW_AT_name        : Left   
> >      DW_AT_byte_size   : 12     
> >      DW_AT_decl_file   : 1      
> >      DW_AT_decl_line   : 2      
> >      DW_AT_containing_type: <22e>       
> >  <2><23f>: Abbrev Number: 22 (DW_TAG_inheritance)
> >      DW_AT_type        : <56>   
> >      DW_AT_data_member_location: 2 byte block: 23 8 (DW_OP_plus_uconst: 8; )
> >      DW_AT_virtuality  : 1      (virtual)
> >      DW_AT_accessibility: 1     (public)
> 
> Yep.  Since Base is a virtual base of Left, the DW_AT_data_member_location
> here should be a complex expression telling the debugger to go through the
> vtable.  I'll get on it.
> 
> I'll also change the stabs output to give the offset within the vtable
> rather than the offset of the base in a complete object; gdb will still
> need to be clever enough to know what to do with it.

I should add: is there some way we can disambiguate correct and
incorrect debug info after this fix?  For Dwarf2 I see how to do it
pretty easily.  Would an explicit minus sign work?  I think GDB won't
croak on that.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  parent reply	other threads:[~2001-11-28 20:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-27 23:03 Daniel Jacobowitz
2001-11-18 21:43 ` Daniel Jacobowitz
2001-11-19  9:04 ` Benjamin Kosnik
2001-11-27 23:36   ` Benjamin Kosnik
2001-11-19 11:16 ` Daniel Berlin
2001-11-21 13:37   ` Dan Mosedale
2001-11-28 12:25     ` Dan Mosedale
2001-11-27 23:43   ` Daniel Berlin
2001-11-19 13:41 ` Jason Merrill
2001-11-28  1:31   ` Jason Merrill
2001-11-28  9:41   ` Daniel Jacobowitz
2001-11-21  4:12     ` Daniel Jacobowitz
2001-11-21  5:06     ` Daniel Berlin
2001-11-28 10:36       ` Daniel Berlin
2001-11-28 10:49       ` Daniel Jacobowitz
2001-11-21 12:33         ` Daniel Jacobowitz
2001-11-28 11:41     ` Jason Merrill
2001-11-21 13:21       ` Jason Merrill
2001-11-21 13:42       ` Daniel Jacobowitz [this message]
2001-11-28 12:32         ` Daniel Jacobowitz
2001-11-21 16:38       ` Jason Merrill
2001-11-22  0:13         ` Daniel Jacobowitz
2001-11-24 22:52           ` Jason Merrill
2001-11-29  9:44             ` Jason Merrill
2001-11-29 12:28             ` Daniel Jacobowitz
2001-11-25  8:34               ` Daniel Jacobowitz
2001-11-25  9:01               ` Kevin Buettner
2001-11-25 10:30                 ` Jason Merrill
2001-11-29 19:12                   ` Jason Merrill
2001-11-29 13:11                 ` Kevin Buettner
2001-11-29 12:50               ` Benjamin Kosnik
2001-11-25  8:40                 ` Benjamin Kosnik
2001-11-28 13:31           ` Daniel Jacobowitz
2001-11-28 13:03         ` Jason Merrill
     [not found]       ` <20011128151819.A31514@nevyn.them.org>
2001-11-21 22:26         ` Jason Merrill
2001-11-28 13:14           ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011128153226.A1557@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox