Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
To: gdb@sources.redhat.com
Subject: prgregset_t vs gdb_gregset_t on Linux: not the same!
Date: Fri, 08 Jun 2001 13:27:00 -0000	[thread overview]
Message-ID: <20010608132730.A4056@nevyn.them.org> (raw)

In proc-service.c, we call fill_gregset and supply_gregset with a
prgregset_t cast to a gdb_gregset_t *.  The problem is, they really are
different.  We can mostly get away with this, because in almost all cases
glibc won't do anything with the gregset except pass it back to gdb again
(if the process has terminated, it will memset something the size of a
prgregset_t, though...).

Now for the reason it's a problem: I don't have any idea where this
definition came from, but a prgregset_t on Linux/MIPS is smaller than an
elf_gregset_t by a considerable amount.  This caused me no end of confusion
while I was trying to add threads support to the MIPS port (which I've just
started feeding back patches for today).

Of course, the thread_db functions are defined to take a prgregset_t, so
it's unclear what we really can do.  Make sure we always allocate the size
of the larger one, perhaps, and assume glibc won't do too much damage?

The prgregset_t type unfortunately is one word too small for all the
registers we can get from ptrace(), even if I fill its pad words with data.

-- 
Daniel Jacobowitz                           Debian GNU/Linux Developer
Monta Vista Software                              Debian Security Team


             reply	other threads:[~2001-06-08 13:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-08 13:27 Daniel Jacobowitz [this message]
2001-06-08 15:58 ` Daniel Jacobowitz
2001-06-08 22:14   ` H . J . Lu
2001-06-09 11:50     ` Mark Kettenis
2001-06-09 13:34     ` Andrew Cagney
2001-06-10  0:23       ` H . J . Lu
     [not found]         ` <Pine.SUN.3.91.1010610105519.5638E-100000@is>
2001-06-10  1:20           ` H . J . Lu
2001-06-11  6:48         ` Andrew Cagney
2001-06-11  8:58           ` H . J . Lu
2001-06-11 10:45             ` Andrew Cagney
2001-06-11  9:24           ` Daniel Jacobowitz
2001-06-11  9:45             ` H . J . Lu
2001-06-11 10:04               ` Daniel Jacobowitz
2001-06-11 10:45                 ` H . J . Lu
2001-06-09 15:23     ` Daniel Jacobowitz
2001-06-09 11:50   ` Mark Kettenis
2001-06-09 15:42     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010608132730.A4056@nevyn.them.org \
    --to=dmj+@andrew.cmu.edu \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox