zillions of testsuite failures

zillions of testsuite failures

[David Carlton]

Is anybody seeing lots of testsuite failures all of a sudden?  I'm
getting huge numbers; many, possibly all of them (e.g. every MI test
fails), seem to have to do with how GDB is invoked.  It seems like, at
some point, invocations start getting

  <directory>/testsuite/gdb.base/args 1 '' '' 3

tacked onto them.  E.g. the last line of gdb.sum is:

/extra/gdb/mirror/src/gdb/testsuite/../../gdb/gdb version  2003-01-15-cvs --args /extra/gdb/mirror/src/gdb/testsuite/gdb.base/args 1 '' '' 3

Looking at this a bit further, it seems like this 'global GDBFLAGS' that
args.exp sets is persisting for the rest of the entire test run.  So I
think there's something wrong with args.exp.

On a separate, I get the following results from gdb.base/advance.exp

Running ./gdb.base/advance.exp ...
PASS: gdb.base/advance.exp: advance line number
PASS: gdb.base/advance.exp: malformed advance
PASS: gdb.base/advance.exp: advance func
FAIL: gdb.base/advance.exp: advance function not called by current frame
FAIL: gdb.base/advance.exp: find line number containing "break here"
PASS: gdb.base/advance.exp: set breakpoint at call to func3
FAIL: gdb.base/advance.exp: continue to call to func3 in main
FAIL: gdb.base/advance.exp: advance function called as param
FAIL: gdb.base/advance.exp: advance with no argument

This happens before the args fiasco, so I think the failures are
legit.  Are they known?  I'll append the relevant part of my gdb.log
after my signature.

David Carlton
carlton@math.stanford.edu

(gdb) run 
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/advance 

Breakpoint 1, main () at gdb.base/advance.c:37
37	  c = 5;
(gdb) list ./gdb.base/advance.c:1,1
No source file named ./gdb.base/advance.c.
(gdb) search advance this location
38	  b = 3;    /* advance this location */
(gdb) advance 38
main () at gdb.base/advance.c:38
38	  b = 3;    /* advance this location */
(gdb) PASS: gdb.base/advance.exp: advance line number
list ./gdb.base/advance.c:1,1
No source file named ./gdb.base/advance.c.
(gdb) search advance malformed
43	  return 0; /* advance malformed */
(gdb) advance 43 then stop
Junk at end of arguments.
(gdb) PASS: gdb.base/advance.exp: malformed advance
advance func
func () at gdb.base/advance.c:18
18	  x = x + 5;
(gdb) PASS: gdb.base/advance.exp: advance func
advance func3
main () at gdb.base/advance.c:41
41	  func3 (); /* break here */
(gdb) FAIL: gdb.base/advance.exp: advance function not called by current frame
list ./gdb.base/advance.c:1,1
No source file named ./gdb.base/advance.c.
(gdb) search break here
Expression not found
(gdb) FAIL: gdb.base/advance.exp: find line number containing "break here"
break -1
Breakpoint 2 at 0x80484aa: file gdb.base/advance.c, line 40.
(gdb) PASS: gdb.base/advance.exp: set breakpoint at call to func3
continue
Continuing.

Program exited normally.
(gdb) FAIL: gdb.base/advance.exp: continue to call to func3 in main
advance foo
The program is not running.
(gdb) FAIL: gdb.base/advance.exp: advance function called as param
advance
The program is not running.
(gdb) FAIL: gdb.base/advance.exp: advance with no argument

Re: zillions of testsuite failures

[Elena Zannoni]

David Carlton writes:
 > Is anybody seeing lots of testsuite failures all of a sudden?  I'm
 > getting huge numbers; many, possibly all of them (e.g. every MI test
 > fails), seem to have to do with how GDB is invoked.  It seems like, at
 > some point, invocations start getting
 > 
 >   <directory>/testsuite/gdb.base/args 1 '' '' 3
 > 

Argh! that's my fault!!! Sorry.
Let me fix it.
I think I set a global and didn't reset it....

Elena


 > tacked onto them.  E.g. the last line of gdb.sum is:
 > 
 > /extra/gdb/mirror/src/gdb/testsuite/../../gdb/gdb version  2003-01-15-cvs --args /extra/gdb/mirror/src/gdb/testsuite/gdb.base/args 1 '' '' 3
 > 
 > Looking at this a bit further, it seems like this 'global GDBFLAGS' that
 > args.exp sets is persisting for the rest of the entire test run.  So I
 > think there's something wrong with args.exp.
 > 
 > On a separate, I get the following results from gdb.base/advance.exp
 > 
 > Running ./gdb.base/advance.exp ...
 > PASS: gdb.base/advance.exp: advance line number
 > PASS: gdb.base/advance.exp: malformed advance
 > PASS: gdb.base/advance.exp: advance func
 > FAIL: gdb.base/advance.exp: advance function not called by current frame
 > FAIL: gdb.base/advance.exp: find line number containing "break here"
 > PASS: gdb.base/advance.exp: set breakpoint at call to func3
 > FAIL: gdb.base/advance.exp: continue to call to func3 in main
 > FAIL: gdb.base/advance.exp: advance function called as param
 > FAIL: gdb.base/advance.exp: advance with no argument
 > 
 > This happens before the args fiasco, so I think the failures are
 > legit.  Are they known?  I'll append the relevant part of my gdb.log
 > after my signature.
 > 
 > David Carlton
 > carlton@math.stanford.edu
 > 
 > (gdb) run 
 > Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/advance 
 > 
 > Breakpoint 1, main () at gdb.base/advance.c:37
 > 37	  c = 5;
 > (gdb) list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.
 > (gdb) search advance this location
 > 38	  b = 3;    /* advance this location */
 > (gdb) advance 38
 > main () at gdb.base/advance.c:38
 > 38	  b = 3;    /* advance this location */
 > (gdb) PASS: gdb.base/advance.exp: advance line number
 > list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.
 > (gdb) search advance malformed
 > 43	  return 0; /* advance malformed */
 > (gdb) advance 43 then stop
 > Junk at end of arguments.
 > (gdb) PASS: gdb.base/advance.exp: malformed advance
 > advance func
 > func () at gdb.base/advance.c:18
 > 18	  x = x + 5;
 > (gdb) PASS: gdb.base/advance.exp: advance func
 > advance func3
 > main () at gdb.base/advance.c:41
 > 41	  func3 (); /* break here */
 > (gdb) FAIL: gdb.base/advance.exp: advance function not called by current frame
 > list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.
 > (gdb) search break here
 > Expression not found
 > (gdb) FAIL: gdb.base/advance.exp: find line number containing "break here"
 > break -1
 > Breakpoint 2 at 0x80484aa: file gdb.base/advance.c, line 40.
 > (gdb) PASS: gdb.base/advance.exp: set breakpoint at call to func3
 > continue
 > Continuing.
 > 
 > Program exited normally.
 > (gdb) FAIL: gdb.base/advance.exp: continue to call to func3 in main
 > advance foo
 > The program is not running.
 > (gdb) FAIL: gdb.base/advance.exp: advance function called as param
 > advance
 > The program is not running.
 > (gdb) FAIL: gdb.base/advance.exp: advance with no argument

Re: zillions of testsuite failures

[Elena Zannoni]

try this for the first problem (args.exp), it seems to work for me, if
it works for you too I'll check it in.

For the second problem, I don't see any failures in my configuration, let me
check again.

Elena


Index: args.exp
===================================================================
RCS file: /cvs/uberbaum/gdb/testsuite/gdb.base/args.exp,v
retrieving revision 1.1
diff -u -p -r1.1 args.exp
--- args.exp	14 Jan 2003 21:03:42 -0000	1.1
+++ args.exp	16 Jan 2003 00:44:12 -0000
@@ -37,6 +37,7 @@ if  { [gdb_compile "${srcdir}/${subdir}/
 #
 # Test that the --args are processed correctly.
 #
+set old_gdbflags $GDBFLAGS
 set GDBFLAGS "--args $binfile 1 3"
 gdb_exit
 gdb_start
@@ -67,4 +68,5 @@ gdb_test "run" \
 	"Starting program.*args 1 \\\\'\\\\' \\\\'\\\\' 3.*5\r\n.*args\r\n1\r\n''\r\n''\r\n3.*Program exited normally." \
 	"correct args printed, two empty"
 
+set GDBFLAGS $old_gdbflags

Re: zillions of testsuite failures

[David Carlton]

On Wed, 15 Jan 2003 19:50:08 -0500, Elena Zannoni <ezannoni@redhat.com> said:

> try this for the first problem (args.exp), it seems to work for me, if
> it works for you too I'll check it in.

Yeah, it works for me.

Though, interestingly, more of the zillions of failures were real than
I thought: besides the aforementioned advance.exp failures, I'm also
seeing failures on:

FAIL: gdb.base/break.exp: break on default location, 2nd time
FAIL: gdb.base/break.exp: break on default location, 3rd time
FAIL: gdb.base/break.exp: break on default location, 4th time

I'll include the log in my signature.

And the two "help until" tests in gdb.base/help.exp are failing; maybe
they're looking for the old text.  (Should there also be a "help
advance" test added?)  And gdb.base/until.exp gives me this; gdb.log
fragment after my signature.

PASS: gdb.base/until.exp: until line number
PASS: gdb.base/until.exp: malformed until
FAIL: gdb.base/until.exp: until factorial, recursive function
FAIL: gdb.base/until.exp: until func, not called by current frame

Hope this helps in figuring out the situation.

David Carlton
carlton@math.stanford.edu

*** Here's the log for break.exp:

Running ./gdb.base/break.exp ...
Executing on host: gcc ./gdb.base/break.c  -w -g  -lm   -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break    (timeout = 300)
spawn gcc ./gdb.base/break.c -w -g -lm -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
Executing on host: gcc ./lib/compiler.c  -E  -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break.ci    (timeout = 300)
spawn gcc ./lib/compiler.c -E -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break.ci 
spawn /extra/gdb/mirror/src/gdb/testsuite/../../gdb/gdb -nw -nx 
GNU gdb 2003-01-15-cvs
Copyright 2003 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu".
(gdb) set height 0
(gdb) set width 0
(gdb) dir
Reinitialize source path to empty? (y or n) y
Source directories searched: $cdir:$cwd
(gdb) dir ./gdb.base
Source directories searched: /extra/gdb/mirror/src/gdb/testsuite/./gdb.base:$cdir:$cwd
(gdb) file /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break
Reading symbols from /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break...done.
(gdb) delete breakpoints
(gdb) PASS: gdb.base/break.exp: Delete all breakpoints when none
break main
Breakpoint 1 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) PASS: gdb.base/break.exp: breakpoint function
break "marker2"
Breakpoint 2 at 0x80484fd: file gdb.base/break.c, line 49.
(gdb) PASS: gdb.base/break.exp: breakpoint quoted function
break break.c:factorial
Breakpoint 3 at 0x80485be: file gdb.base/break.c, line 96.
(gdb) PASS: gdb.base/break.exp: breakpoint function in file
list main
65	int
66	main (argc, argv, envp)
67	int argc;
68	char *argv[], **envp;
69	#endif
70	{
71	#ifdef usestubs
72	    set_debug_traps();
73	    breakpoint();
74	#endif
(gdb) PASS: gdb.base/break.exp: use `list' to establish default source file
break 79
Breakpoint 4 at 0x8048547: file gdb.base/break.c, line 79.
(gdb) PASS: gdb.base/break.exp: breakpoint line number
break 79
Note: breakpoint 4 also set at pc 0x8048547.
Breakpoint 5 at 0x8048547: file gdb.base/break.c, line 79.
(gdb) PASS: gdb.base/break.exp: breakpoint duplicate
break break.c:85
Breakpoint 6 at 0x804859c: file gdb.base/break.c, line 85.
(gdb) PASS: gdb.base/break.exp: breakpoint line number in file
break multi_line_if_conditional
Breakpoint 7 at 0x80485e6: file gdb.base/break.c, line 109.
(gdb) PASS: gdb.base/break.exp: breakpoint at start of multi line if conditional
break multi_line_while_conditional
Breakpoint 8 at 0x8048612: file gdb.base/break.c, line 124.
(gdb) PASS: gdb.base/break.exp: breakpoint at start of multi line while conditional
info break
Num Type           Disp Enb Address    What
1   breakpoint     keep y   0x08048520 in main at gdb.base/break.c:75
2   breakpoint     keep y   0x080484fd in marker2 at gdb.base/break.c:49
3   breakpoint     keep y   0x080485be in factorial at gdb.base/break.c:96
4   breakpoint     keep y   0x08048547 in main at gdb.base/break.c:79
5   breakpoint     keep y   0x08048547 in main at gdb.base/break.c:79
6   breakpoint     keep y   0x0804859c in main at gdb.base/break.c:85
7   breakpoint     keep y   0x080485e6 in multi_line_if_conditional at gdb.base/break.c:109
8   breakpoint     keep y   0x08048612 in multi_line_while_conditional at gdb.base/break.c:124
(gdb) PASS: gdb.base/break.exp: breakpoint info
run
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 1, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) PASS: gdb.base/break.exp: run until function breakpoint
continue
Continuing.

Breakpoint 4, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:79
79	    printf ("%d\n", factorial (atoi ("6")));
(gdb) PASS: gdb.base/break.exp: run until breakpoint set at a line number
continue
Continuing.

Breakpoint 3, factorial (value=6) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(6) breakpoint
continue
Continuing.

Breakpoint 3, factorial (value=5) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(5) breakpoint
continue
Continuing.

Breakpoint 3, factorial (value=4) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(4) breakpoint
continue
Continuing.

Breakpoint 3, factorial (value=3) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(3) breakpoint
continue
Continuing.

Breakpoint 3, factorial (value=2) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(2) breakpoint
continue
Continuing.

Breakpoint 3, factorial (value=1) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: run until file:function(1) breakpoint
continue
Continuing.
720

Breakpoint 2, 0x080484fd in marker2 (a=43) at gdb.base/break.c:49
49	int marker2 (a) int a; { return (1); }
(gdb) PASS: gdb.base/break.exp: run until quoted breakpoint
continue
Continuing.

Breakpoint 6, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:85
85	    argc = (argc == 12345); /* This is silly, but we can step off of it */
(gdb) PASS: gdb.base/break.exp: run until file:linenum breakpoint
break +1
Breakpoint 9 at 0x80485ac: file gdb.base/break.c, line 86.
(gdb) PASS: gdb.base/break.exp: breakpoint offset +1
step

Breakpoint 9, main (argc=0, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:86
86	    return argc;
(gdb) PASS: gdb.base/break.exp: step onto breakpoint
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) tbreak main
Breakpoint 10 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint function
tbreak break.c:factorial
Breakpoint 11 at 0x80485be: file gdb.base/break.c, line 96.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint function in file
tbreak 79
Breakpoint 12 at 0x8048547: file gdb.base/break.c, line 79.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint line number #1
tbreak 75
Note: breakpoint 10 also set at pc 0x8048520.
Breakpoint 13 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint line number #2
tbreak break.c:85
Breakpoint 14 at 0x804859c: file gdb.base/break.c, line 85.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint line number in file #1
tbreak break.c:81
Breakpoint 15 at 0x804856b: file gdb.base/break.c, line 81.
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint line number in file #2
info break
Num Type           Disp Enb Address    What
10  breakpoint     del  y   0x08048520 in main at gdb.base/break.c:75
11  breakpoint     del  y   0x080485be in factorial at gdb.base/break.c:96
12  breakpoint     del  y   0x08048547 in main at gdb.base/break.c:79
13  breakpoint     del  y   0x08048520 in main at gdb.base/break.c:75
14  breakpoint     del  y   0x0804859c in main at gdb.base/break.c:85
15  breakpoint     del  y   0x0804856b in main at gdb.base/break.c:81
(gdb) PASS: gdb.base/break.exp: Temporary breakpoint info
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break main
Breakpoint 16 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 16, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) catch
Catch requires an event name.
(gdb) PASS: gdb.base/break.exp: catch requires an event name
catch fork
Catch of fork not yet implemented
(gdb) PASS: gdb.base/break.exp: set catch fork, never expected to trigger
catch vfork
Catch of vfork not yet implemented
(gdb) PASS: gdb.base/break.exp: set catch vfork, never expected to trigger
catch exec
Catch of exec not yet implemented
(gdb) PASS: gdb.base/break.exp: set catch exec, never expected to trigger
break 999
No line 999 in file "gdb.base/break.c".
(gdb) PASS: gdb.base/break.exp: break on non-existent source line
break
Note: breakpoint 16 also set at pc 0x8048520.
Breakpoint 17 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) PASS: gdb.base/break.exp: break on default location, 1st time
break
Note: breakpoints 16 and 17 also set at pc 0x8048520.
Breakpoint 18 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) FAIL: gdb.base/break.exp: break on default location, 2nd time
break
Note: breakpoints 16, 17 and 18 also set at pc 0x8048520.
Breakpoint 19 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) FAIL: gdb.base/break.exp: break on default location, 3rd time
break
Note: breakpoints 16, 17, 18 and 19 also set at pc 0x8048520.
Breakpoint 20 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) FAIL: gdb.base/break.exp: break on default location, 4th time
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break main
Breakpoint 21 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 21, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) break 79
Breakpoint 22 at 0x8048547: file gdb.base/break.c, line 79.
(gdb) PASS: gdb.base/break.exp: set to-be-silent break 79
commands 22
Type commands for when breakpoint 22 is hit, one per line.
End with a line saying just "end".
>silent
>end
(gdb) PASS: gdb.base/break.exp: set silent break 79
info break 22
Num Type           Disp Enb Address    What
22  breakpoint     keep y   0x08048547 in main at gdb.base/break.c:79
        silent
(gdb) PASS: gdb.base/break.exp: info silent break 79
continue
Continuing.
(gdb) PASS: gdb.base/break.exp: hit silent break 79
bt
#0  main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:79
(gdb) PASS: gdb.base/break.exp: stopped for silent break 79
break 80 thread 999
Unknown thread 999

(gdb) PASS: gdb.base/break.exp: thread-specific breakpoint on non-existent thread disallowed
break 80 thread foo
Junk after thread keyword.
(gdb) PASS: gdb.base/break.exp: thread-specific breakpoint on bogus thread ID disallowed
break 80 foo
Junk at end of arguments.
(gdb) PASS: gdb.base/break.exp: breakpoint with trailing garbage disallowed
next
720
81	    marker1 ();
(gdb) PASS: gdb.base/break.exp: step over breakpoint
clear 81
No breakpoint at 81.
(gdb) PASS: gdb.base/break.exp: clear line has no breakpoint disallowed
clear
No breakpoint at this line.
(gdb) PASS: gdb.base/break.exp: clear current line has no breakpoint disallowed
break marker3
Breakpoint 23 at 0x8048507: file gdb.base/break.c, line 50.
(gdb) PASS: gdb.base/break.exp: break marker3 #1
break marker3
Note: breakpoint 23 also set at pc 0x8048507.
Breakpoint 24 at 0x8048507: file gdb.base/break.c, line 50.
(gdb) PASS: gdb.base/break.exp: break marker3 #2
clear marker3
Deleted breakpoints 24 23 
(gdb) PASS: gdb.base/break.exp: clear marker3
set $foo=81
(gdb) PASS: gdb.base/break.exp: set convenience variable $foo to 81
break $foo
Breakpoint 25 at 0x804856b: file gdb.base/break.c, line 81.
(gdb) PASS: gdb.base/break.exp: set breakpoint via convenience variable
set $foo=81.5
(gdb) PASS: gdb.base/break.exp: set convenience variable $foo to 81.5
break $foo
Convenience variables used in line specs must have integer values.
(gdb) PASS: gdb.base/break.exp: set breakpoint via non-integer convenience variable disallowed
break marker2
Breakpoint 26 at 0x80484fd: file gdb.base/break.c, line 49.
(gdb) PASS: gdb.base/break.exp: set breakpoint on to-be-called function
print marker2(99)

Breakpoint 26, 0x080484fd in marker2 (a=99) at gdb.base/break.c:49
49	int marker2 (a) int a; { return (1); }
The program being debugged stopped while in a function called from GDB.
When the function (marker2) is done executing, GDB will silently
stop (instead of continuing to evaluate the expression containing
the function call).
(gdb) PASS: gdb.base/break.exp: hit breakpoint on called function
bt
#0  0x080484fd in marker2 (a=99) at gdb.base/break.c:49
#1  <function called from gdb>
#2  main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:81
(gdb) PASS: gdb.base/break.exp: backtrace while in called function
finish
Run till exit from #0  0x080484fd in marker2 (a=99) at gdb.base/break.c:49
Value returned is $1 = 1
(gdb) PASS: gdb.base/break.exp: finish from called function
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break main
Breakpoint 27 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 27, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) finish 123
The "finish" command does not take any arguments.
(gdb) PASS: gdb.base/break.exp: finish with arguments disallowed
finish
"finish" not meaningful in the outermost frame.
(gdb) PASS: gdb.base/break.exp: finish from outermost frame disallowed
kill
Kill the program being debugged? (y or n) y
(gdb) PASS: gdb.base/break.exp: kill program
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break factorial
Breakpoint 28 at 0x80485be: file gdb.base/break.c, line 96.
(gdb) PASS: gdb.base/break.exp: break at factorial
run 
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 28, factorial (value=6) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) continue
Continuing.

Breakpoint 28, factorial (value=5) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) PASS: gdb.base/break.exp: continue to factorial(5)
backtrace
#0  factorial (value=5) at gdb.base/break.c:96
#1  0x080485d0 in factorial (value=6) at gdb.base/break.c:97
#2  0x0804855b in main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:79
(gdb) PASS: gdb.base/break.exp: backtrace from factorial(5)
next
97		value *= factorial (value - 1);
(gdb) PASS: gdb.base/break.exp: next to recursive call
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) next
99	    return (value);
(gdb) PASS: gdb.base/break.exp: next over recursive call
backtrace
#0  factorial (value=120) at gdb.base/break.c:99
#1  0x080485d0 in factorial (value=6) at gdb.base/break.c:97
#2  0x0804855b in main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:79
(gdb) PASS: gdb.base/break.exp: backtrace from factorial(5.1)
continue
Continuing.
720

Program exited normally.
(gdb) PASS: gdb.base/break.exp: continue until exit at recursive next test
Executing on host: gcc ./gdb.base/break.c  "-O2" -g  -lm   -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2    (timeout = 300)
spawn gcc ./gdb.base/break.c -O2 -g -lm -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2 
Executing on host: gcc ./lib/compiler.c  -E  -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2.ci    (timeout = 300)
spawn gcc ./lib/compiler.c -E -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2.ci 
spawn /extra/gdb/mirror/src/gdb/testsuite/../../gdb/gdb -nw -nx 
GNU gdb 2003-01-15-cvs
Copyright 2003 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu".
(gdb) set height 0
(gdb) set width 0
(gdb) dir
Reinitialize source path to empty? (y or n) y
Source directories searched: $cdir:$cwd
(gdb) dir ./gdb.base
Source directories searched: /extra/gdb/mirror/src/gdb/testsuite/./gdb.base:$cdir:$cwd
(gdb) file /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2
Reading symbols from /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2...done.
(gdb) break main
Breakpoint 1 at 0x8048549: file gdb.base/break.c, line 75.
(gdb) PASS: gdb.base/break.exp: breakpoint function, optimized file
break marker4
Breakpoint 2 at 0x8048533: file gdb.base/break.c, line 51.
(gdb) PASS: gdb.base/break.exp: breakpoint small function, optimized file
run
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/breako2 

Breakpoint 1, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) PASS: gdb.base/break.exp: run until function breakpoint, optimized file
continue
Continuing.
720

Breakpoint 2, 0x08048533 in marker4 (d=177601976) at gdb.base/break.c:51
51	void marker4 (d) long d; {}
PASS: gdb.base/break.exp: run until breakpoint set at small function, optimized file
testcase ./gdb.base/break.exp completed in 6 seconds



*** Here's the log for until.exp:

Running ./gdb.base/until.exp ...
Executing on build: rm -f /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break    (timeout = 300)
spawn rm -f /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
Executing on host: gcc ./gdb.base/break.c  -g  -lm   -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break    (timeout = 300)
spawn gcc ./gdb.base/break.c -g -lm -o /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
spawn /extra/gdb/mirror/src/gdb/testsuite/../../gdb/gdb -nw -nx 
GNU gdb 2003-01-15-cvs
Copyright 2003 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu".
(gdb) set height 0
(gdb) set width 0
(gdb) dir
Reinitialize source path to empty? (y or n) y
Source directories searched: $cdir:$cwd
(gdb) dir ./gdb.base
Source directories searched: /extra/gdb/mirror/src/gdb/testsuite/./gdb.base:$cdir:$cwd
(gdb) file /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break
Reading symbols from /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break...done.
(gdb) delete breakpoints
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break main
Breakpoint 1 at 0x8048520: file gdb.base/break.c, line 75.
(gdb) run 
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 1, main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:75
75	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */
(gdb) until 79
main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:79
79	    printf ("%d\n", factorial (atoi ("6")));
(gdb) PASS: gdb.base/until.exp: until line number
until 80 then stop
Junk at end of arguments.
(gdb) PASS: gdb.base/until.exp: malformed until
delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break factorial
Breakpoint 2 at 0x80485be: file gdb.base/break.c, line 96.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 

Breakpoint 2, factorial (value=6) at gdb.base/break.c:96
96	    if (value > 1) {
(gdb) delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until 99
factorial (value=720) at gdb.base/break.c:99
99	    return (value);
(gdb) FAIL: gdb.base/until.exp: until factorial, recursive function
delete breakpoints
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break marker2
Breakpoint 3 at 0x80484fd: file gdb.base/break.c, line 49.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
720

Breakpoint 3, 0x080484fd in marker2 (a=43) at gdb.base/break.c:49
49	int marker2 (a) int a; { return (1); }
(gdb) delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until marker3
main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:83
83	    marker3 ("stack", "trace");
(gdb) FAIL: gdb.base/until.exp: until func, not called by current frame
testcase ./gdb.base/until.exp completed in 2 seconds

Re: zillions of testsuite failures

[Elena Zannoni]

David Carlton writes:
 > On Wed, 15 Jan 2003 19:50:08 -0500, Elena Zannoni <ezannoni@redhat.com> said:
 > 
 > > try this for the first problem (args.exp), it seems to work for me, if
 > > it works for you too I'll check it in.
 > 
 > Yeah, it works for me.
 > 

I checked that in.

 > Though, interestingly, more of the zillions of failures were real than
 > I thought: besides the aforementioned advance.exp failures, I'm also
 > seeing failures on:
 > 
 > FAIL: gdb.base/break.exp: break on default location, 2nd time
 > FAIL: gdb.base/break.exp: break on default location, 3rd time
 > FAIL: gdb.base/break.exp: break on default location, 4th time
 > 

I really didn't pay enough attention. Sorry.
This is a weird one. Since I removed the 'until' tests from before these
'set breakpoint at default location' tests, the default location has changed,
and so the tests are failing.

 > I'll include the log in my signature.
 > 
 > And the two "help until" tests in gdb.base/help.exp are failing; maybe
 > they're looking for the old text.  (Should there also be a "help
 > advance" test added?)  And gdb.base/until.exp gives me this; gdb.log
 > fragment after my signature.

Grunt. Not my day.
I'll post a patch right away.


 > 
 > PASS: gdb.base/until.exp: until line number
 > PASS: gdb.base/until.exp: malformed until
 > FAIL: gdb.base/until.exp: until factorial, recursive function
 > FAIL: gdb.base/until.exp: until func, not called by current frame
 >

This seems to be caused by the different source file that gets printed
in your gdb.log, like for advance.exp.
 
 > (gdb) until 99
 > factorial (value=720) at gdb.base/break.c:99
 > 99	    return (value);
 > (gdb) FAIL: gdb.base/until.exp: until factorial, recursive function
 > delete breakpoints
 > (gdb) info breakpoints
 > No breakpoints or watchpoints.
 > (gdb) break marker2
 > Breakpoint 3 at 0x80484fd: file gdb.base/break.c, line 49.
 > (gdb) run 
 > The program being debugged has been started already.
 > Start it from the beginning? (y or n) y
 > Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
 > 720
 > 
 > Breakpoint 3, 0x080484fd in marker2 (a=43) at gdb.base/break.c:49
 > 49	int marker2 (a) int a; { return (1); }
 > (gdb) delete breakpoints
 > Delete all breakpoints? (y or n) y
 > (gdb) info breakpoints
 > No breakpoints or watchpoints.
 > (gdb) until marker3
 > main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:83
 > 83	    marker3 ("stack", "trace");
 > (gdb) FAIL: gdb.base/until.exp: until func, not called by current frame
 > testcase ./gdb.base/until.exp completed in 2 seconds


I get:

(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until 99
factorial (value=720) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:99
99          return (value);
(gdb) PASS: gdb.base/until.exp: until factorial, recursive function
delete breakpoints
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break marker2
Breakpoint 3 at 0x804850f: file /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c, line 49.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ezannoni/sources/native/gdb/testsuite/gdb.base/break 
720

Breakpoint 3, 0x0804850f in marker2 (a=43) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:49
49      int marker2 (a) int a; { return (1); }
(gdb) delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until marker3
0x08048593 in main (argc=1, argv=0xbfffd974, envp=0xbfffd97c) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:82
82          marker2 (43);
(gdb) PASS: gdb.base/until.exp: until func, not called by current frame
testcase /home/ezannoni/sources/src/gdb/testsuite/gdb.base/until.exp completed in 4 seconds

Re: zillions of testsuite failures

[Elena Zannoni]

David Carlton writes:
 > (gdb) run 
 > Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/advance 
 > 
 > Breakpoint 1, main () at gdb.base/advance.c:37
 > 37	  c = 5;
 > (gdb) list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.

this is the problem, it is searching in the wrong spot for the source file,
In my gdb.log I have:

Breakpoint 1, main () at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/advance.c:37
37        c = 5;
(gdb) list /home/ezannoni/sources/src/gdb/testsuite/gdb.base/advance.c:1,1
1       
(gdb) search advance this location
38        b = 3;    /* advance this location */
(gdb) advance 38

Seems that gdb_get_line_number doesn't know the ${srcfile} correctly.

More digging....

 > (gdb) search advance this location
 > 38	  b = 3;    /* advance this location */
 > (gdb) advance 38
 > main () at gdb.base/advance.c:38
 > 38	  b = 3;    /* advance this location */
 > (gdb) PASS: gdb.base/advance.exp: advance line number
 > list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.
 > (gdb) search advance malformed
 > 43	  return 0; /* advance malformed */
 > (gdb) advance 43 then stop
 > Junk at end of arguments.
 > (gdb) PASS: gdb.base/advance.exp: malformed advance
 > advance func
 > func () at gdb.base/advance.c:18
 > 18	  x = x + 5;
 > (gdb) PASS: gdb.base/advance.exp: advance func
 > advance func3
 > main () at gdb.base/advance.c:41
 > 41	  func3 (); /* break here */
 > (gdb) FAIL: gdb.base/advance.exp: advance function not called by current frame
 > list ./gdb.base/advance.c:1,1
 > No source file named ./gdb.base/advance.c.
 > (gdb) search break here
 > Expression not found
 > (gdb) FAIL: gdb.base/advance.exp: find line number containing "break here"
 > break -1
 > Breakpoint 2 at 0x80484aa: file gdb.base/advance.c, line 40.
 > (gdb) PASS: gdb.base/advance.exp: set breakpoint at call to func3
 > continue
 > Continuing.
 > 
 > Program exited normally.
 > (gdb) FAIL: gdb.base/advance.exp: continue to call to func3 in main
 > advance foo
 > The program is not running.
 > (gdb) FAIL: gdb.base/advance.exp: advance function called as param
 > advance
 > The program is not running.
 > (gdb) FAIL: gdb.base/advance.exp: advance with no argument