From: Doug Evans <dje@transmeta.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb@sources.redhat.com
Subject: Re: does bpstat_print stop printing prematurely?
Date: Tue, 16 Apr 2002 08:43:00 -0000 [thread overview]
Message-ID: <15548.18095.721341.436541@casey.transmeta.com> (raw)
In-Reply-To: <4060-Tue16Apr2002154926+0300-eliz@is.elta.co.il>
Eli Zaretskii writes:
> > From: Doug Evans <dje@transmeta.com>
> > Date: Mon, 15 Apr 2002 23:43:34 -0700 (PDT)
> >
> > Here's a session showing how to recreate it.
>
> Thanks, I reproduced the bug on my machine. However, I don't know
> what would it take to fix this, since I don't understand the comment
> in bpstat_print before the offending loop. Anybody?
Assuming one decides to print all breakpoints, either move the
control for source/frame printing into bpstat_print or pull
the loop in bpstat_print into normal_stop().
Also, in the case of pc breakpoints, there's no need to print the
source line for each one. Printing that only once would be fine.
[maybe "printing" it multiple times would confuse programs parsing
the output]
You might even want to do a preprocessing pass and sort them.
Since bpstat_print wants to stop when it wants the caller to print
the source location (Vega, right smack dab in the middle, but I digress),
maybe the thing to do is print all non-pc-breakpoints first, then
all pc-breakpoints last, defering the source location to the last
pc breakpoint.
Maybe the preprocessing pass would be where `print_it_done' is handled
and nothing is printed, even if other breakpoints want to be printed.
next prev parent reply other threads:[~2002-04-16 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-15 13:03 Doug Evans
2002-04-15 22:03 ` Eli Zaretskii
2002-04-15 23:43 ` Doug Evans
2002-04-16 0:40 ` Eli Zaretskii
2002-04-16 5:55 ` Eli Zaretskii
2002-04-16 8:43 ` Doug Evans [this message]
2002-04-16 10:50 ` Doug Evans
2002-05-09 20:44 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15548.18095.721341.436541@casey.transmeta.com \
--to=dje@transmeta.com \
--cc=eliz@is.elta.co.il \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox