From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13661 invoked by alias); 16 Apr 2002 15:43:51 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 13653 invoked from network); 16 Apr 2002 15:43:50 -0000 Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196) by sources.redhat.com with SMTP; 16 Apr 2002 15:43:50 -0000 Received: (from root@localhost) by neon-gw.transmeta.com (8.9.3/8.9.3) id IAA18772; Tue, 16 Apr 2002 08:43:46 -0700 Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1) id xma018756; Tue, 16 Apr 02 08:43:41 -0700 Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22]) by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id g3GFhhN25988; Tue, 16 Apr 2002 08:43:43 -0700 (PDT) Received: (from dje@localhost) by casey.transmeta.com (8.9.3/8.7.3) id IAA03684; Tue, 16 Apr 2002 08:43:43 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15548.18095.721341.436541@casey.transmeta.com> Date: Tue, 16 Apr 2002 08:43:00 -0000 To: Eli Zaretskii Cc: gdb@sources.redhat.com Subject: Re: does bpstat_print stop printing prematurely? In-Reply-To: <4060-Tue16Apr2002154926+0300-eliz@is.elta.co.il> References: <200204152003.NAA11126@casey.transmeta.com> <15547.51222.125386.852824@casey.transmeta.com> <4060-Tue16Apr2002154926+0300-eliz@is.elta.co.il> X-SW-Source: 2002-04/txt/msg00266.txt.bz2 Eli Zaretskii writes: > > From: Doug Evans > > Date: Mon, 15 Apr 2002 23:43:34 -0700 (PDT) > > > > Here's a session showing how to recreate it. > > Thanks, I reproduced the bug on my machine. However, I don't know > what would it take to fix this, since I don't understand the comment > in bpstat_print before the offending loop. Anybody? Assuming one decides to print all breakpoints, either move the control for source/frame printing into bpstat_print or pull the loop in bpstat_print into normal_stop(). Also, in the case of pc breakpoints, there's no need to print the source line for each one. Printing that only once would be fine. [maybe "printing" it multiple times would confuse programs parsing the output] You might even want to do a preprocessing pass and sort them. Since bpstat_print wants to stop when it wants the caller to print the source location (Vega, right smack dab in the middle, but I digress), maybe the thing to do is print all non-pc-breakpoints first, then all pc-breakpoints last, defering the source location to the last pc breakpoint. Maybe the preprocessing pass would be where `print_it_done' is handled and nothing is printed, even if other breakpoints want to be printed.