Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Martin M. Hunt" <hunt@redhat.com>
To: gdb@sources.redhat.com
Subject: dwarf2-frame.c question for maintainers
Date: Tue, 13 Jul 2004 22:01:00 -0000	[thread overview]
Message-ID: <1089749730.3026.18.camel@dragon> (raw)

I'm working on some dwarf2 fixes with kevinb.  In
dwarf2_build_frame_info(), Kevin added 
+unit.signed_addr_p = bfd_get_sign_extend_vma (unit.abfd);

This is useful for fixing several bugs where addresses needed to be
sign-extended.  However, I found that read_reg() also needs to
sign-extend its result.  Passing a pointer to the CU all the way down to
read_reg doesn't seem practical.

I don't have any understanding of the overall structure of this code or
where it is going. I can see several possibilities, including the
obvious one; using a global. So how do I solve this to get the patch
accepted?

Martin


             reply	other threads:[~2004-07-13 20:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-13 22:01 Martin M. Hunt [this message]
2004-07-14 17:29 ` Andrew Cagney
2004-07-14 17:56   ` Martin M. Hunt
2004-07-14 19:38     ` Andrew Cagney
2004-07-15 17:32       ` Mark Kettenis
2004-07-15 17:40       ` Martin M. Hunt
2004-07-15 18:15         ` Andrew Cagney
2004-07-15 18:35           ` Martin M. Hunt
2004-07-15 18:45             ` Andrew Cagney
2004-07-15 18:54               ` Martin M. Hunt
2004-07-16 21:16                 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089749730.3026.18.camel@dragon \
    --to=hunt@redhat.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox