From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7476 invoked by alias); 13 Jul 2004 20:15:38 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 7466 invoked from network); 13 Jul 2004 20:15:37 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Jul 2004 20:15:37 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6DKFae1031746 for ; Tue, 13 Jul 2004 16:15:36 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6DKFa005362 for ; Tue, 13 Jul 2004 16:15:36 -0400 Received: from [172.16.50.50] (vpn50-50.rdu.redhat.com [172.16.50.50]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i6DKFaVZ003461 for ; Tue, 13 Jul 2004 16:15:36 -0400 Subject: dwarf2-frame.c question for maintainers From: "Martin M. Hunt" To: gdb@sources.redhat.com Content-Type: text/plain Organization: Red Hat Inc. Message-Id: <1089749730.3026.18.camel@dragon> Mime-Version: 1.0 Date: Tue, 13 Jul 2004 22:01:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00123.txt.bz2 I'm working on some dwarf2 fixes with kevinb. In dwarf2_build_frame_info(), Kevin added +unit.signed_addr_p = bfd_get_sign_extend_vma (unit.abfd); This is useful for fixing several bugs where addresses needed to be sign-extended. However, I found that read_reg() also needs to sign-extend its result. Passing a pointer to the CU all the way down to read_reg doesn't seem practical. I don't have any understanding of the overall structure of this code or where it is going. I can see several possibilities, including the obvious one; using a global. So how do I solve this to get the patch accepted? Martin