Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@kealia.com>
To: gdb-patches@sources.redhat.com
Subject: [rfa] add DMGL_PARAMS (was: new demangler)
Date: Tue, 16 Dec 2003 16:54:00 -0000	[thread overview]
Message-ID: <yf2he00u2hq.fsf_-_@hawaii.kealia.com> (raw)
In-Reply-To: <20031216053022.GA28127@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 16 Dec 2003 00:30:22 -0500")

On Tue, 16 Dec 2003 00:30:22 -0500, Daniel Jacobowitz <drow@mvista.com> said:
> On Mon, Dec 15, 2003 at 03:38:28PM -0800, David Carlton wrote:

>> Okay; I'll just stick in the DMGL_PARAMS for now, then - my tests
>> start passing again with that change.  (Or I could rewrite the code
>> that parses the output to not look for parentheses, I suppose.)

> Do the former for now.

The latter actually should be easy enough given the parsing
functionality that's already in cp-support.c, but I have no objection
to the former, which I present here.  Is it okay for mainline?  Tested
on i686-pc-linux-gnu, GCC 3.2, DWARF 2; no regressions.  (No tests,
but it's necessary for my current patch awaiting approval to work
properly.)

David Carlton
carlton@kealia.com

2003-12-16  David Carlton  <carlton@kealia.com>

	* cp-support.c (class_name_from_physname): Add DMGL_PARAMS.
	(method_name_from_physname): Ditto.

Index: cp-support.c
===================================================================
RCS file: /cvs/src/src/gdb/cp-support.c,v
retrieving revision 1.10
diff -u -p -r1.10 cp-support.c
--- cp-support.c	5 Dec 2003 04:25:09 -0000	1.10
+++ cp-support.c	16 Dec 2003 16:52:10 -0000
@@ -145,7 +145,7 @@ class_name_from_physname (const char *ph
   char *ret = NULL;
   const char *end;
   int depth = 0;
-  char *demangled_name = cplus_demangle (physname, DMGL_ANSI);
+  char *demangled_name = cplus_demangle (physname, DMGL_ANSI | DMGL_PARAMS);
 
   if (demangled_name == NULL)
     return NULL;
@@ -170,7 +170,7 @@ method_name_from_physname (const char *p
   char *ret = NULL;
   const char *end;
   int depth = 0;
-  char *demangled_name = cplus_demangle (physname, DMGL_ANSI);
+  char *demangled_name = cplus_demangle (physname, DMGL_ANSI | DMGL_PARAMS);
 
   if (demangled_name == NULL)
     return NULL;


       reply	other threads:[~2003-12-16 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <yf2llpdvgko.fsf@hawaii.kealia.com>
     [not found] ` <20031215225452.GA23169@nevyn.them.org>
     [not found]   ` <yf2he01vg6z.fsf@hawaii.kealia.com>
     [not found]     ` <m3y8tdfzir.fsf@gossamer.airs.com>
     [not found]       ` <yf2d6apvfg2.fsf@hawaii.kealia.com>
     [not found]         ` <m3u141fz28.fsf@gossamer.airs.com>
     [not found]           ` <m3ptepfyxh.fsf@gossamer.airs.com>
     [not found]             ` <yf28yldvevq.fsf@hawaii.kealia.com>
     [not found]               ` <m3he01fygc.fsf@gossamer.airs.com>
     [not found]                 ` <yf23cblveh7.fsf@hawaii.kealia.com>
     [not found]                   ` <20031216053022.GA28127@nevyn.them.org>
2003-12-16 16:54                     ` David Carlton [this message]
2003-12-16 19:23                       ` Daniel Jacobowitz
2003-12-16 19:27                         ` [rfa] add DMGL_PARAMS David Carlton
2003-12-16 17:15 [rfa] add DMGL_PARAMS (was: new demangler) Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yf2he00u2hq.fsf_-_@hawaii.kealia.com \
    --to=carlton@kealia.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox