From: David Carlton <carlton@kealia.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] some -Wformat-nonliteral changes
Date: Mon, 04 Aug 2003 17:14:00 -0000 [thread overview]
Message-ID: <yf24r0x1h1d.fsf@hawaii.kealia.com> (raw)
In-Reply-To: <3F2E6837.4010201@redhat.com> (Andrew Cagney's message of "Mon, 04 Aug 2003 10:05:43 -0400")
On Mon, 04 Aug 2003 10:05:43 -0400, Andrew Cagney <ac131313@redhat.com> said:
> Insert expression of disbelief:
>> - internal_error ("Error converting character `%d' from `%s' to `%s' "
>> + internal_error (__FILE__, __LINE__,
>> + "Error converting character `%d' from `%s' to `%s' "
>> "character set: %s",
>> from_char, ci->from->name, ci->to->name,
>> safe_strerror (errno));
We can be pleased at GDB's robustness that this internal error doesn't
get triggered. :-)
> Yes, ok, and yes, the internal_error patch should go onto the
> branch.
Great; I've committed all of it to mainline, and the internal_error
part to the branch.
> Before reverting -Wformat-nonliteral, I'd like to see exactly what the
> damange is - it's clearly finding bugs.
Okay, but I'll continue to grumble... :-)
David Carlton
carlton@kealia.com
prev parent reply other threads:[~2003-08-04 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-01 20:30 David Carlton
2003-08-04 14:06 ` Andrew Cagney
2003-08-04 17:14 ` David Carlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf24r0x1h1d.fsf@hawaii.kealia.com \
--to=carlton@kealia.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox