From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20688 invoked by alias); 4 Aug 2003 17:14:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20669 invoked from network); 4 Aug 2003 17:14:38 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 4 Aug 2003 17:14:38 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 5AF28BFE1; Mon, 4 Aug 2003 10:14:38 -0700 (PDT) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] some -Wformat-nonliteral changes References: <3F2E6837.4010201@redhat.com> From: David Carlton Date: Mon, 04 Aug 2003 17:14:00 -0000 In-Reply-To: <3F2E6837.4010201@redhat.com> (Andrew Cagney's message of "Mon, 04 Aug 2003 10:05:43 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00040.txt.bz2 On Mon, 04 Aug 2003 10:05:43 -0400, Andrew Cagney said: > Insert expression of disbelief: >> - internal_error ("Error converting character `%d' from `%s' to `%s' " >> + internal_error (__FILE__, __LINE__, >> + "Error converting character `%d' from `%s' to `%s' " >> "character set: %s", >> from_char, ci->from->name, ci->to->name, >> safe_strerror (errno)); We can be pleased at GDB's robustness that this internal error doesn't get triggered. :-) > Yes, ok, and yes, the internal_error patch should go onto the > branch. Great; I've committed all of it to mainline, and the internal_error part to the branch. > Before reverting -Wformat-nonliteral, I'd like to see exactly what the > damange is - it's clearly finding bugs. Okay, but I'll continue to grumble... :-) David Carlton carlton@kealia.com