Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: John Baldwin <jhb@freebsd.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Remove ioctl-based procfs support on Solaris
Date: Wed, 27 Sep 2017 08:48:00 -0000	[thread overview]
Message-ID: <yddpoacttli.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <5190367.sVyILAhGg6@ralph.baldwin.cx> (John Baldwin's message of	"Tue, 26 Sep 2017 13:49:06 -0700")

Hi John,

> FYI, bsd-kvm.c uses HAVE_SYS_USER_H and also uses _KMEMUSER (which your
> ChangeLog mentions, but I didn't see it removed in the configure.ac diff)
> bsd-kvm.c also uses <sys/proc.h> but it uses it unconditionally.

good catch.  The bulk of patch was developed several months ago, and I
neglected to re-check every single detail.  I've now restored the
sys/user.h check, which is really needed according to your comment.

The _KMEMUSER removal was mentioned in the ChangeLog because it was
present when I started the patch, but had been gone already in the
meantime.

Speaking of header guards, I noticed that HAVE_SYS_SYSCALL_H was still
present in config.in (and gdbserver/config.in) although I'd removed it
from configure.ac.  Turned out that it crept back via common/common.m4.
Given that there are no more users, I've removed it there, too, and
regenerated the affected files (configure, config.in,
gdbserver/configure, gdbserver/config.in).

That's all in the incremental patch posted in response to Pedro's
comments.

Thanks for the heads-up.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


      reply	other threads:[~2017-09-27  8:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26 12:25 Rainer Orth
2017-09-26 14:03 ` Pedro Alves
2017-09-27  8:44   ` Rainer Orth
2017-09-27 11:07     ` Pedro Alves
2017-11-30 13:42       ` Rainer Orth
2017-11-30 14:51         ` Pedro Alves
2017-09-26 21:09 ` John Baldwin
2017-09-27  8:48   ` Rainer Orth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yddpoacttli.fsf@CeBiTec.Uni-Bielefeld.DE \
    --to=ro@cebitec.uni-bielefeld.de \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox