From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52374 invoked by alias); 27 Sep 2017 08:48:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52363 invoked by uid 89); 27 Sep 2017 08:48:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*i:John X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Sep 2017 08:48:47 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C8F0B1C0; Wed, 27 Sep 2017 10:48:44 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id F1dyadHIJF-l; Wed, 27 Sep 2017 10:48:43 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 1B12F1BF; Wed, 27 Sep 2017 10:48:43 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v8R8mfFr014731; Wed, 27 Sep 2017 10:48:41 +0200 (MEST) From: Rainer Orth To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: Remove ioctl-based procfs support on Solaris References: <5190367.sVyILAhGg6@ralph.baldwin.cx> Date: Wed, 27 Sep 2017 08:48:00 -0000 In-Reply-To: <5190367.sVyILAhGg6@ralph.baldwin.cx> (John Baldwin's message of "Tue, 26 Sep 2017 13:49:06 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-09/txt/msg00820.txt.bz2 Hi John, > FYI, bsd-kvm.c uses HAVE_SYS_USER_H and also uses _KMEMUSER (which your > ChangeLog mentions, but I didn't see it removed in the configure.ac diff) > bsd-kvm.c also uses but it uses it unconditionally. good catch. The bulk of patch was developed several months ago, and I neglected to re-check every single detail. I've now restored the sys/user.h check, which is really needed according to your comment. The _KMEMUSER removal was mentioned in the ChangeLog because it was present when I started the patch, but had been gone already in the meantime. Speaking of header guards, I noticed that HAVE_SYS_SYSCALL_H was still present in config.in (and gdbserver/config.in) although I'd removed it from configure.ac. Turned out that it crept back via common/common.m4. Given that there are no more users, I've removed it there, too, and regenerated the affected files (configure, config.in, gdbserver/configure, gdbserver/config.in). That's all in the incremental patch posted in response to Pedro's comments. Thanks for the heads-up. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University