Re: PATCH: Fix gdb compilation on Tru64 UNIX

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
> Rainer> napms() is declared only if _XOPEN_SOURCE_EXTENDED is defined, which
> Rainer> requires _XOPEN_SOURCE >= 420.
>
> Rainer> 2010-01-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> Rainer> 	* gdb_curses.h [__osf__] (_XOPEN_SOURCE, _XOPEN_SOURCE_EXTENDED)
> Rainer> 	Define.
> Rainer> 	* solib-osf.c (osf_current_sos): Initialize tail.
>
> The solib-osf.c change is ok.
>
> I am not as sure about the gdb_curses.h change.  I don't think we have
> many host tests like that.  Perhaps some kind of configury would be
> better.

True.  While researching where/how best to handle this in configure.ac,
I found that TUI wasn't supposed to be built on Tru64 UNIX at all.
Unfortunately, the test is completely broken and can never have worked:

* The test checks $host_os, but tries to match it against the full
  target triplet, which fails since host_os is only the third component.

* Both if conditions failed to invoke the test command, but instead
  tried to execute the value of $enable_tui as a command.

After fixing those issues, TUI is disabled on alpha-dec-osf5.1b (tested
by removing the gdb subdir and running make again) and gdb builds
without problems.

Ok?
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2010-01-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* configure.ac: Only use host_os part when disabling TUI on osf.
	Use test to check variables, prefix strings with x.
	* configure: Regenerate.

Index: gdb/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.112
diff -u -p -r1.112 configure.ac
--- gdb/configure.ac	15 Jan 2010 00:34:37 -0000	1.112
+++ gdb/configure.ac	21 Jan 2010 22:44:01 -0000
@@ -447,11 +447,11 @@ AM_ICONV
 # broken on alpha-osf.
 
 case $host_os in
-  alpha*-*-osf* )
-    if "$enable_tui" = "yes"; then
+  osf* )
+    if test x"$enable_tui" = xyes; then
       AC_MSG_ERROR([Building GDB with TUI mode is not supported on this host])
     fi
-    if "$enable_tui" = "auto"; then
+    if test x"$enable_tui" = xauto; then
       enable_tui=no
     fi
     ;;