From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30883 invoked by alias); 21 Jan 2010 22:49:52 -0000 Received: (qmail 30872 invoked by uid 22791); 21 Jan 2010 22:49:50 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jan 2010 22:49:45 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0B5DDDB8; Thu, 21 Jan 2010 23:49:43 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9NpKZ6QwDwOq; Thu, 21 Jan 2010 23:49:40 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6CD39DB7; Thu, 21 Jan 2010 23:49:40 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.3+Sun/8.14.3/Submit) id o0LMneW2010600; Thu, 21 Jan 2010 23:49:40 +0100 (MET) From: Rainer Orth To: tromey@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: PATCH: Fix gdb compilation on Tru64 UNIX References: Date: Thu, 21 Jan 2010 22:49:00 -0000 In-Reply-To: (Tom Tromey's message of "Thu, 21 Jan 2010 10:05:09 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00540.txt.bz2 Tom Tromey writes: >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> napms() is declared only if _XOPEN_SOURCE_EXTENDED is defined, which > Rainer> requires _XOPEN_SOURCE >= 420. > > Rainer> 2010-01-18 Rainer Orth > Rainer> * gdb_curses.h [__osf__] (_XOPEN_SOURCE, _XOPEN_SOURCE_EXTENDED) > Rainer> Define. > Rainer> * solib-osf.c (osf_current_sos): Initialize tail. > > The solib-osf.c change is ok. > > I am not as sure about the gdb_curses.h change. I don't think we have > many host tests like that. Perhaps some kind of configury would be > better. True. While researching where/how best to handle this in configure.ac, I found that TUI wasn't supposed to be built on Tru64 UNIX at all. Unfortunately, the test is completely broken and can never have worked: * The test checks $host_os, but tries to match it against the full target triplet, which fails since host_os is only the third component. * Both if conditions failed to invoke the test command, but instead tried to execute the value of $enable_tui as a command. After fixing those issues, TUI is disabled on alpha-dec-osf5.1b (tested by removing the gdb subdir and running make again) and gdb builds without problems. Ok? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2010-01-21 Rainer Orth * configure.ac: Only use host_os part when disabling TUI on osf. Use test to check variables, prefix strings with x. * configure: Regenerate. Index: gdb/configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.112 diff -u -p -r1.112 configure.ac --- gdb/configure.ac 15 Jan 2010 00:34:37 -0000 1.112 +++ gdb/configure.ac 21 Jan 2010 22:44:01 -0000 @@ -447,11 +447,11 @@ AM_ICONV # broken on alpha-osf. case $host_os in - alpha*-*-osf* ) - if "$enable_tui" = "yes"; then + osf* ) + if test x"$enable_tui" = xyes; then AC_MSG_ERROR([Building GDB with TUI mode is not supported on this host]) fi - if "$enable_tui" = "auto"; then + if test x"$enable_tui" = xauto; then enable_tui=no fi ;;