Re: [PATCH] move sparc-sol-thread.c back into sol-thread.c.

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Joel,

> Contrary to what the man page says, the routines in sparc-sol-thread
> are needed on some non-SPARC systems, more precisly on x86_64.
> So this patch deletes sparc-sol-thread.c and moves the code back
> inside sol-thread.c, with some added comments warning the reader
> about this pitfall.

I've done some digging and found that xregs on Solaris/amd64 were added
for AVX support, in Solaris 10 Update 10 apparently:

http://www.mail-archive.com/opensolaris-arc@opensolaris.org/msg01454.html

As we already found, whether or not you find ps_lgetxregsize documented
as SPARC-specific depends on the version of the Solaris 10 man pages you
are looking at, and in S11 it has been there from the beginning.  So
please adapt the comments accordingly, or even leave out the x86_64
reference altogether.

> gdb/ChangeLog:
>
>         PR tdep/15420:
>         * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
>         New functions, directly copied from sparc-sol-thread.c.
>         * sparc-sol-thread.c: Delete.
>         * configure.ac: Remove code handling sparc-solaris-thread.c.
>         * configure: Regenerate.
>
> Tested on sparc-solaris. Rainer, would you mind confirming that this
> fixes your problem as well?

I've removed my configure hack to use sparc-sol-thread.c everywhere,
applied your patch and rebuilt gdb: it works just fine now.

Thanks.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University