From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2051 invoked by alias); 10 May 2013 11:10:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2035 invoked by uid 89); 10 May 2013 11:10:37 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_TX autolearn=ham version=3.3.1 Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 11:10:35 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 64964605; Fri, 10 May 2013 13:10:32 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zs7XUDcesHRh; Fri, 10 May 2013 13:10:30 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6D3F8603; Fri, 10 May 2013 13:10:30 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id r4ABAUH5004100; Fri, 10 May 2013 13:10:30 +0200 (MEST) From: Rainer Orth To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] move sparc-sol-thread.c back into sol-thread.c. References: <1367842203-31747-1-git-send-email-brobecker@adacore.com> Date: Fri, 10 May 2013 11:10:00 -0000 In-Reply-To: <1367842203-31747-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 6 May 2013 08:10:03 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00375.txt.bz2 Hi Joel, > Contrary to what the man page says, the routines in sparc-sol-thread > are needed on some non-SPARC systems, more precisly on x86_64. > So this patch deletes sparc-sol-thread.c and moves the code back > inside sol-thread.c, with some added comments warning the reader > about this pitfall. I've done some digging and found that xregs on Solaris/amd64 were added for AVX support, in Solaris 10 Update 10 apparently: http://www.mail-archive.com/opensolaris-arc@opensolaris.org/msg01454.html As we already found, whether or not you find ps_lgetxregsize documented as SPARC-specific depends on the version of the Solaris 10 man pages you are looking at, and in S11 it has been there from the beginning. So please adapt the comments accordingly, or even leave out the x86_64 reference altogether. > gdb/ChangeLog: > > PR tdep/15420: > * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs): > New functions, directly copied from sparc-sol-thread.c. > * sparc-sol-thread.c: Delete. > * configure.ac: Remove code handling sparc-solaris-thread.c. > * configure: Regenerate. > > Tested on sparc-solaris. Rainer, would you mind confirming that this > fixes your problem as well? I've removed my configure hack to use sparc-sol-thread.c everywhere, applied your patch and rebuilt gdb: it works just fine now. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University