Re: [PATCH] Provide Solaris 11 buildbots

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

Hi Sergio,

>>> So, there were a few problems in the master.cfg file which prevented the
>>> builders to actually build GDB.  I fixed them, and they're now
>>> processing the queue.  However, the builds are failing.  For example:
>>>
>>>   https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/3/steps/compile%20gdb/logs/stdio
>>>
>>> This seems to be the problem you were talking about, regarding
>>> unittests/string_view-selftests.o.  You mentioned that this breakage
>>> shouldn't happen if we don't use -D_GLIBCXX_DEBUG, right?  Can you
>>> please take a look at this?
>>
>> until your --enable-unit-tests patch is in (when we can keep the default
>> options and just add --disable-unit-tests to the configure line), we'd
>> need to build with CFLAGS/CXXFLAGS=-g -O -D_GLIBCXX_DEBUG until PR
>> build/23676 is resolved.  That's what worked for me locally.
>
> Ah, I thought that if we didn't use "-g -D_GLIBCXX_DEBUG", then the
> build would be OK.

That's what I tried first when I encountered the problem here.  However,
even the minimal testcase in the PR fails with just -g alone.

Could you please try if the following patch allows the build to succeed?

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: solaris-O.patch --]
[-- Type: text/x-patch, Size: 1053 bytes --]

diff --git a/master.cfg b/master.cfg
--- a/master.cfg
+++ b/master.cfg
@@ -1293,7 +1293,8 @@ class RunTestGDBSolaris_Common (BuildAnd
         # build/23676.  This can be avoided either by performing a -g
         # -O build or with --disable-unit-tests from Sergio's proposed
         # patch.
-        self.disable_default_compilation_flags = True
+        self.extra_CFLAGS = [ '-O' ]
+        self.extra_CXXFLAGS = self.extra_CFLAGS
         BuildAndTestGDBFactory.__init__ (self, **kwargs)
 
 class RunTestGDBPlainSolaris_c64 (RunTestGDBSolaris_Common):
@@ -1309,7 +1310,8 @@ class RunTestGDBPlainSolaris_c64 (RunTes
         # build/23676.  This can be avoided either by performing a -g
         # -O build or with --disable-unit-tests from Sergio's proposed
         # patch.
-        self.disable_default_compilation_flags = True
+        self.extra_CFLAGS = [ '-O' ]
+        self.extra_CXXFLAGS = self.extra_CFLAGS
         BuildAndTestGDBFactory.__init__ (self, **kwargs)
 
 # Classes needed for ARM (running on Aarch64, on Yao's buildslave)