Re: [PATCH] Provide Solaris 11 buildbots

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Monday, September 24 2018, Rainer Orth wrote:

> Hi Sergio,
>
>>>>> So, there were a few problems in the master.cfg file which prevented the
>>>>> builders to actually build GDB.  I fixed them, and they're now
>>>>> processing the queue.  However, the builds are failing.  For example:
>>>>>
>>>>>   https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/3/steps/compile%20gdb/logs/stdio
>>>>>
>>>>> This seems to be the problem you were talking about, regarding
>>>>> unittests/string_view-selftests.o.  You mentioned that this breakage
>>>>> shouldn't happen if we don't use -D_GLIBCXX_DEBUG, right?  Can you
>>>>> please take a look at this?
>>>>
>>>> until your --enable-unit-tests patch is in (when we can keep the default
>>>> options and just add --disable-unit-tests to the configure line), we'd
>>>> need to build with CFLAGS/CXXFLAGS=-g -O -D_GLIBCXX_DEBUG until PR
>>>> build/23676 is resolved.  That's what worked for me locally.
>>>
>>> Ah, I thought that if we didn't use "-g -D_GLIBCXX_DEBUG", then the
>>> build would be OK.
>>
>> That's what I tried first when I encountered the problem here.  However,
>> even the minimal testcase in the PR fails with just -g alone.
>>
>> Could you please try if the following patch allows the build to succeed?
>
> it seems we managed to mess up the configure flags badly here: right now
> the buildbots are configured with just CFLAGS/CXXFLAGS=-m64, nothing
> more.  I hope the following patch should fix things:

Ah, OK.  I may have misunderstood the patch/requirements.  I've now
simplified the configuration.

> * There's no need for disable_default_compilation_flags = True: the
>   default works just fine, we only need to add -O at the moment.  Isn't
>   it enough to do this once in RunTestGDBSolaris_Common?

Yeah, it should be.

> * Obviously the -m64 needs to be appended in RunTestGDBPlainSolaris_c64
>   to both CFLAGS and CXXFLAGS to avoid losing the -O above.

Yeah.

> * Not in the patch, but wouldn't it be enough to set enable_targets_all,
>   make_command, and run_testsuite only once in RunTestGDBSolaris_Common?

It turned out to be a bit more complicated.  I'm in a hurry right now,
so I did a quick hack to make it work.  I'll monitor the next builds.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/