From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>,
<gdb-patches@sourceware.org>,
Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2 10/17] gdbserver: pass pointer to struct tracepoint to install_fast_tracepoint_jump_pad
Date: Wed, 15 Jun 2016 15:42:00 -0000 [thread overview]
Message-ID: <wwokvb1acvcv.fsf@ericsson.com> (raw)
In-Reply-To: <3c04a051-f12a-c757-60be-2b666b1a770f@0x04.net>
Marcin Kościelnicki writes:
> On 09/06/16 14:56, Antoine Tremblay wrote:
>> From: Simon Marchi <simon.marchi@ericsson.com>
>>
>> We currently pass many values to install_fast_tracepoint_jump_pad that
>> come from fields of struct tracepoint, and we plan to add another (the
>> kind field). It would be simpler to just pass a pointer to the
>> tracepoint and have install_fast_tracepoint_jump_pad fetch the fields
>> from it.
>>
>> That requires moving the struct tracepoint definition to tracepoint.h.
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * linux-aarch64-low.c (aarch64_install_fast_tracepoint_jump_pad):
>> Replaces some parameters with a struct tracepoint *.
>
> The same needs to be done for s390 and powerpc.
>
Right, forgot to update the patchset with this.
Will do thx.
>> * linux-low.c (linux_install_fast_tracepoint_jump_pad):
>> Likewise.
>> * linux-low.h (struct linux_target_ops)
>> <install_fast_tracepoint_jump_pad>: Likewise.
>> * linux-x86-low.c (amd64_install_fast_tracepoint_jump_pad): Likewise.
>> (i386_install_fast_tracepoint_jump_pad): Likewise.
>> (x86_install_fast_tracepoint_jump_pad): Likewise.
>> * target.h (struct tracepoint): New forward declaration.
>> (struct target_ops) <install_fast_tracepoint_jump_pad>: Replace
>> some parameters with a struct tracepoint *.
>> (install_fast_tracepoint_jump_pad): Likewise.
>> * tracepoint.c (enum tracepoint_type): Move to tracepoint.h.
>> (struct tracepoint): Likewise.
>> (install_fast_tracepoint): Adapt call to
>> install_fast_tracepoint_jump_pad.
>> * tracepoint.h (enum tracepoint_type) Moved from tracepoint.c.
>> (struct tracepoint): Moved from tracepoint.c.
>> ---
>> gdb/gdbserver/linux-aarch64-low.c | 26 ++++----
>> gdb/gdbserver/linux-arm-low.c | 2 +
>> gdb/gdbserver/linux-low.c | 12 +---
>> gdb/gdbserver/linux-low.h | 5 +-
>> gdb/gdbserver/linux-x86-low.c | 63 ++++++++----------
>> gdb/gdbserver/target.h | 26 ++++----
>> gdb/gdbserver/tracepoint.c | 131 +-------------------------------------
>> gdb/gdbserver/tracepoint.h | 125 ++++++++++++++++++++++++++++++++++++
>> 8 files changed, 179 insertions(+), 211 deletions(-)
next prev parent reply other threads:[~2016-06-15 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 12:56 [PATCH v2 00/17] Fast tracepoint support for ARMv7 Antoine Tremblay
2016-06-09 12:56 ` [PATCH v2 06/17] arm-tdep.c: Use relocation visitor in Thumb 16-bits instruction decoding Antoine Tremblay
2016-06-09 12:56 ` [PATCH v2 08/17] Move Thumb 32 bits instruction decode functions to arch/arm-insn-reloc.c Antoine Tremblay
2016-06-09 12:56 ` [PATCH v2 11/17] Use software single step to step out of a fast tracepoint jump pad Antoine Tremblay
2016-06-09 12:56 ` [PATCH v2 07/17] Move ARM instruction decode functions to arch/arm-insn-reloc.c Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 15/17] arm: Move insn_references_pc to common code Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 05/17] arm-tdep.c: Use relocation visitor in Thumb 32-bits instruction decoding Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 14/17] JIT conditions support for ARM tracepoints Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 13/17] Fast tracepoint support for ARM on Linux Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 01/17] arm-tdep.c: Replace arguments to decode function by a structure Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 10/17] gdbserver: pass pointer to struct tracepoint to install_fast_tracepoint_jump_pad Antoine Tremblay
2016-06-15 14:59 ` Marcin Kościelnicki
2016-06-15 15:42 ` Antoine Tremblay [this message]
2016-06-16 17:14 ` [PATCH v3] " Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 03/17] arm-tdep.c: Move debug printout from decode to copy function Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 16/17] arm fast tracepoints: Relocation of ARM instructions Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 12/17] Add ARM/Thumb instruction assembler for fast tracepoints Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 02/17] arm-tdep.c: Refactor displaced stepping relocation functions Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 04/17] arm-tdep.c: Use relocation visitor in ARM instruction decoding Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 17/17] arm fast tracepoints: Relocation of Thumb 32-bits instructions Antoine Tremblay
2016-06-09 12:57 ` [PATCH v2 09/17] Move Thumb 16 bits instruction decode functions to arch/arm-insn-reloc.c Antoine Tremblay
2016-06-29 13:55 ` [PATCH v2 00/17] Fast tracepoint support for ARMv7 Antoine Tremblay
2016-06-29 16:59 ` Pedro Alves
2016-06-29 19:15 ` Antoine Tremblay
2016-06-29 20:10 ` Pedro Alves
2016-06-30 11:46 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wwokvb1acvcv.fsf@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox