From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93365 invoked by alias); 15 Jun 2016 15:42:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93322 invoked by uid 89); 15 Jun 2016 15:42:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=thx, ko=c5, HContent-Transfer-Encoding:8bit?= X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Jun 2016 15:41:56 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 1B.1E.09012.6AD61675; Wed, 15 Jun 2016 17:00:55 +0200 (CEST) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.93) with Microsoft SMTP Server (TLS) id 14.3.294.0; Wed, 15 Jun 2016 11:41:53 -0400 References: <1465476975-25062-1-git-send-email-antoine.tremblay@ericsson.com> <1465476975-25062-11-git-send-email-antoine.tremblay@ericsson.com> <3c04a051-f12a-c757-60be-2b666b1a770f@0x04.net> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= CC: Antoine Tremblay , , Simon Marchi Subject: Re: [PATCH v2 10/17] gdbserver: pass pointer to struct tracepoint to install_fast_tracepoint_jump_pad In-Reply-To: <3c04a051-f12a-c757-60be-2b666b1a770f@0x04.net> Date: Wed, 15 Jun 2016 15:42:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00267.txt.bz2 Marcin Kościelnicki writes: > On 09/06/16 14:56, Antoine Tremblay wrote: >> From: Simon Marchi >> >> We currently pass many values to install_fast_tracepoint_jump_pad that >> come from fields of struct tracepoint, and we plan to add another (the >> kind field). It would be simpler to just pass a pointer to the >> tracepoint and have install_fast_tracepoint_jump_pad fetch the fields >> from it. >> >> That requires moving the struct tracepoint definition to tracepoint.h. >> >> gdb/gdbserver/ChangeLog: >> >> * linux-aarch64-low.c (aarch64_install_fast_tracepoint_jump_pad): >> Replaces some parameters with a struct tracepoint *. > > The same needs to be done for s390 and powerpc. > Right, forgot to update the patchset with this. Will do thx. >> * linux-low.c (linux_install_fast_tracepoint_jump_pad): >> Likewise. >> * linux-low.h (struct linux_target_ops) >> : Likewise. >> * linux-x86-low.c (amd64_install_fast_tracepoint_jump_pad): Likewise. >> (i386_install_fast_tracepoint_jump_pad): Likewise. >> (x86_install_fast_tracepoint_jump_pad): Likewise. >> * target.h (struct tracepoint): New forward declaration. >> (struct target_ops) : Replace >> some parameters with a struct tracepoint *. >> (install_fast_tracepoint_jump_pad): Likewise. >> * tracepoint.c (enum tracepoint_type): Move to tracepoint.h. >> (struct tracepoint): Likewise. >> (install_fast_tracepoint): Adapt call to >> install_fast_tracepoint_jump_pad. >> * tracepoint.h (enum tracepoint_type) Moved from tracepoint.c. >> (struct tracepoint): Moved from tracepoint.c. >> --- >> gdb/gdbserver/linux-aarch64-low.c | 26 ++++---- >> gdb/gdbserver/linux-arm-low.c | 2 + >> gdb/gdbserver/linux-low.c | 12 +--- >> gdb/gdbserver/linux-low.h | 5 +- >> gdb/gdbserver/linux-x86-low.c | 63 ++++++++---------- >> gdb/gdbserver/target.h | 26 ++++---- >> gdb/gdbserver/tracepoint.c | 131 +------------------------------------- >> gdb/gdbserver/tracepoint.h | 125 ++++++++++++++++++++++++++++++++++++ >> 8 files changed, 179 insertions(+), 211 deletions(-)