From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>,
<qiyaoltc@gmail.co>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32
Date: Mon, 09 Jan 2017 17:41:00 -0000 [thread overview]
Message-ID: <wwok4m18ces7.fsf@ericsson.com> (raw)
In-Reply-To: <20170109173056.GB9518@E107787-LIN>
Yao Qi writes:
> On 16-12-09 07:46:25, Antoine Tremblay wrote:
>>
>> This situation is tested with non-stop-fair-events.exp.
>>
>> In other words, single-step breakpoints are installed in proceed_one_lwp
>> for each thread. GDBserver proceeds two threads for resume_step, as
>> requested by GDB, and the thread proceeded later may see the single-step
>> breakpoints installed for the thread proceeded just now.
>>
>> Tested on gdbserver-native/-m{thumb,arm} no regressions.
>
> I assume this patch fixes fails in non-stop-fair-events.exp.
No, it helps but fails are still present, to fix things you need
https://sourceware.org/ml/gdb-patches/2016-11/msg00939.html
and
https://sourceware.org/ml/gdb-patches/2016-11/msg00940.html
If you can take a look at those too it would be nice ?
>
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * linux-aarch32-low.c (arm_breakpoint_kind_from_pc): Use
>> target_read_memory.
>> * linux-arm-low.c (get_next_pcs_read_memory_unsigned_integer): Likewise.
>> (get_next_pcs_syscall_next_pc): Likewise.
>
> Patch is good to me.
Patch is pushed in.
prev parent reply other threads:[~2017-01-09 17:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 12:28 [PATCH 1/3] " Antoine Tremblay
2016-11-28 12:28 ` [PATCH 3/3] Fix inferior memory reading in GDBServer for sparc Antoine Tremblay
2016-12-09 12:51 ` Antoine Tremblay
2016-11-28 12:28 ` [PATCH 2/3] Fix inferior memory reading in GDBServer for ppc Antoine Tremblay
2016-11-30 20:46 ` [PATCH 1/3] Fix inferior memory reading in GDBServer for arm/aarch32 Luis Machado
2016-12-01 14:44 ` Yao Qi
2016-12-01 15:28 ` Antoine Tremblay
2016-12-01 15:55 ` Antoine Tremblay
2016-12-01 16:18 ` Antoine Tremblay
2016-12-01 18:10 ` Antoine Tremblay
2016-12-09 12:06 ` Yao Qi
2016-12-09 12:22 ` [PATCH v2] " Antoine Tremblay
2016-12-09 12:23 ` [PATCH 1/3] " Yao Qi
2016-12-09 12:46 ` [PATCH v3] " Antoine Tremblay
2017-01-09 11:55 ` Antoine Tremblay
2017-01-09 17:31 ` Yao Qi
2017-01-09 17:41 ` Antoine Tremblay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wwok4m18ces7.fsf@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.co \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox