From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79957 invoked by alias); 9 Jan 2017 17:41:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79939 invoked by uid 89); 9 Jan 2017 17:41:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Antoine, H*r:ip*153.88.183.21, H*RU:153.88.183.21, 161209 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jan 2017 17:41:14 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by (Symantec Mail Security) with SMTP id 33.CA.17130.63BC3785; Mon, 9 Jan 2017 18:41:12 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Jan 2017 18:41:53 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.4; Mon, 9 Jan 2017 17:41:07 +0000 References: <20161209122339.GG13661@E107787-LIN> <20161209124625.31861-1-antoine.tremblay@ericsson.com> <20170109173056.GB9518@E107787-LIN> User-agent: mu4e 0.9.19; emacs 25.1.2 From: Antoine Tremblay To: Yao Qi CC: Antoine Tremblay , , Subject: Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32 In-Reply-To: <20170109173056.GB9518@E107787-LIN> Date: Mon, 09 Jan 2017 17:41:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY4PR21CA0014.namprd21.prod.outlook.com (10.172.122.152) To HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) X-MS-Office365-Filtering-Correlation-Id: 7015abc2-f790-4fe8-d2ca-08d438b6b1ed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;3:8FBNrBIbNkc3AVuwXZikuADJh+5JA+jCoODNvwGEGBTi2TR30ZznPBCGKqpSm/MuwHaqMH2EZDoPLgZdMoX63abQ+EJg3fksWzL2brpEC+AgmwVBMy75MbMe9UYpapMzhx0UxhuDnG1MhOImdC9WwXuz8UGL2MFOOXfpvwg7UIfr1RhOsm0RG8jRTwOivieJUH+o7B4LriVK0WHZNKYCqAaan2f8Ar20zaCk4wqYmwpJfXGYIbeD3clnD+wAWKa/mC7D5FBDEFnowOoUme8AyA==;25:0byQg+DILJ+2Y+jxRmtp6iS1iFHbb1GNbe73vZd2oNKJF9OvBi7kTLMMZ/5Z9vgYGaVrMpd9h6rHeyd6jOCnl84yWJe6lFnx+wfS9yFbzklOG7EzUgjFWLLhOmfWjDqiqqYLnDhvSKwB5PlztOo1iaHCuBf12hyg1eQE+NjLASBZJVXLRrCPDgEA8nEBLqTWpdZ1DOmaz8Qo29iCI7M5pVyUFIT0gNu5P8kGPAFDqMnvK3u3nnyrL7WGn6gIsu+pWht0FaQi3kr5VVLWJTlxIEdeTeMgU1+9FhPoM5FEErYbfaVnJLp70XGlmeOjuSzdVecxYj0PVUT7CW5oTZQBn7yu6ri4u1YZHeZyMeth/YloR90L5jpzMDX7GAGRynqZHp2lJtX8y8AWy1B2NQEXHKTJEsJD6LV1O1wnan3OaygOw4+mYzXGVoP9UfPbs9zhOD/5E1Q0ff1YmXaKp+yJIg== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;31:WF40OvswpU+p7ossq8Lp5E30gcgHtTajkXj+idCNImidPXc27WcvmIZloMdMBXbc1zTqWaUi3hYn4ntNI1QfQUSlX64jlIJKiP7SBa8pUK8f9TFlMonnTunL0GqkiDHUmqJYNZ5i/VVPjVRYZEkH6ICpPZXX5ZMTy3+0b05G7UDZsYstly+hUWy31sJVPfg/NwdR/GZXW3STwt6GDMufJNy7WgfaCc1+hbxg3vu1g2e0chUbQw2vTOw6cZLyTmSs;20:WO12uxFohRiOdFBZmY8atI9f0unKA0clVqCJhm1d9YXRuANZmxuL0JZ15L5vrliKwcU49rom/TFr2qosi6i3c92Ct1WJgSyVvzKw7H8csN+3EyHS5cl9OQlUKo4ITuvxb4ugC7du/hpS4LPwNuKp4QljYO9CbkyFxEfI1FzB9l2lYwTZM+CHxsvd/eJo4c6/vtJ+SPtlIyWcyuQI8kpLKrK39kBXN9jAX9FgP3pKoaBOJdhYpvdyY9xIK7H/j5wrfr+Obxmq7/L2Sl6mUIrXstfs/Dk/yIvkAJHmJNH1N58ExxkLCUbF98mdL05R1FX4/rBQbSktCNXELyP2N7NaKUt0sTM6eok3A0meKWmRGTJd61Oeh/ssSgaYBgSRaF0RzEWWerrpR1edM76cVZ/aHQHqW7/ok9OJpwJyySm0j9hMkv49vnv3TZE6hjiEF5No9JMeTdTewDaorbbYFcVMH4CIWAl9BXlaKur6ZEq/UkM0OIuAvV5ikRcXKczFEIqT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:HE1PR0701MB1884;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;4:qlKMJIsH7064SXuA6peGBCHIUWtE3L8Gwo14WdKmMdoozNYWqWiZIQne6j52eFh8mWByua5ChAeRBMZozBVb5yjFMCzjSGAyKQQZ1bfyiivkRuxKcHymbOP5EA7Mdp2Ypz5JZbw0WKRzBepqx0tYXw/hnnq03NomxbLIiBz5UjZckPKCwCS4YFoastjw8B85fI09Vq83Cb/prh1Baj1h132cxlo+PPcFG1vdM3UUaJbaKoKj5bh9N7rd+Su/szcadPbJqbtXb6CdpyqemZDGLbtl/YZRwGpBkEItHnfrmjdg4K6wNQM0zxfm16oK+I+K6a82/mf1DyE32fW8/nQ/sXCPMlQ53cxV6A1hIsUWVLbupEtaJ05b8D+E1jR5HlyZ3YCjYFCb7eDcXjTsv/lguj0xBpkOMaysOcD9M3qxTnYU1+c7Az6rkP/tq4qKpTWfXdU2C72Bbfy4HnDhWyBmjeF+MUJzx9B0Mny8piCMvh8kSAyFK+nn6FljvHeseB123fcm8ISecPtjd1S5cMhaAXgLsOLbl5kuiGIPv1fszagR1eZbApCMeGoB0IK/EdgxgADvQA2Y3Y3Y0pzACXA+fw== X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(377424004)(54534003)(189002)(199003)(68736007)(5003940100001)(92566002)(5660300001)(83506001)(86362001)(2906002)(4326007)(2950100002)(6666003)(6916009)(48376002)(7736002)(66066001)(50466002)(38730400001)(229853002)(8676002)(81166006)(81156014)(4001350100001)(25786008)(54356999)(305945005)(6496003)(39060400001)(97736004)(33646002)(47776003)(54906002)(110136003)(6116002)(101416001)(3846002)(42186005)(1411001)(189998001)(36756003)(50986999)(6486002)(6306002)(76176999)(106356001)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1884;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1884;23:A8EPdpyN3dHOBIHJicVAT97Jr9KQ3nqAGHLH14Z?= =?us-ascii?Q?NTsUh4A7RO0pu4uIwnWyD9pG0fS6zE8mNWJILbQIqfm2BefP4xYa6du0OVjH?= =?us-ascii?Q?1ND4Tgl81CjGRvzii4JoLTBXfZmHEePJASyZtuIU2q1jFNs9Wv/rbNSj5pnv?= =?us-ascii?Q?mTeCTiFd4ctbzLAtTYsMhWFFN0q6AwNCFjoXbilx2qMjibkvbpmcF0ddait+?= =?us-ascii?Q?8A39CXi0dce3kOO+t3u4Nsi4yu13XSyFHgjdS+InnJ1McNe0OhSB8tcCFxNV?= =?us-ascii?Q?3nOZN1pTOjEHqG81gWYCWpNKPxRg+No+EMyb/L/ZWuooC4XHeYFdHLjdNuMW?= =?us-ascii?Q?Shh9GU/rdTdFVQ+F+n92qo9lSq4XMsbg9vn1mcZLhq+nvWc2BGLacemCDY66?= =?us-ascii?Q?142PUsz+Da6yxHwz3oO4wUZrpWDEGJYJiwIbke6pPKjtm+X7XtwBnezEFl61?= =?us-ascii?Q?gNkvR1kX/8AT7P12oFW6HnRkJ9Yn1FkwQ8jPMjxBNZgTbvLZwqK7yPnK2QB9?= =?us-ascii?Q?BkkP3EceNloEzck7lwvU/e1ratej/WKoN+BmyVB/neb8VFwLV2lWLj0ydMqs?= =?us-ascii?Q?kxmIIyaj1DikeOaAfbycAeLl/ewNgQzTwlczhjBvmWTmJG2TZpAzRAeHcE31?= =?us-ascii?Q?+AsGLZYefaJp6SwzfOTt3+AobIvohspSjW1a64k+xm+2WU74aaWg5UjxRccm?= =?us-ascii?Q?pPO6t/wxZl0T9HkDa8ZoDRul/Uh79vUnnrWbkoOMcLDRILpd3KQHp1V+3J2w?= =?us-ascii?Q?YhaS8vdlZ1nMb1uXDCeh/edi5ea5jYeKzM+glsDiSq94HuYt+cbErOLyOT16?= =?us-ascii?Q?ESRZIuFHACJVSpQ76IBJNIXAWXmKKDV+63mFGjbzX1PBFaeT52nd4xKq/V4a?= =?us-ascii?Q?stCk8b/WESAj+zPVH0zkkTE+lIkhuNrV4pFbO/bCR0X4Kx6vfEPr24xoD2lU?= =?us-ascii?Q?S4xpO1JC9v+50xYNNL3nLDAyAmIa5RzNQG9ZzL39U0QR5K34fcLCKq5Ru5XA?= =?us-ascii?Q?jCMavhGHAp5+o6cAVm7D33TYpODtFzsZPHZzIw7doFuqJn4WouEx1cJ+4LKI?= =?us-ascii?Q?CHybb4a50cq2bmrP76I47PVWBOxSahM1RBwFd1y0MiJCSuvVbQCdPwWl1VL2?= =?us-ascii?Q?p3HuIIz4GuiQbnDxgFEU8tvkUdqr00y+Or1pXcZxBK/t2gtqifG3+sji1qEa?= =?us-ascii?Q?DE1fnIUvR2wL2ecL0aMRrGSBAsqbD7X0p4M6wz31Nwk4l0+dcm/Vf2XRtYUv?= =?us-ascii?Q?Y8Pfz7HbEtgvhYthgkxCu4gnDwm6Gx12TOYEN7eiAxy4M/RB6cs00fSByaBc?= =?us-ascii?Q?uyQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;6:rNXbGrE2EFIGUoooN/5/d1lp/QT5GRk+ltMTrI9kQUnqNaIHJsO9GCEghPiQkjzoJyzjnsV4WnRPAxZLV6NeJJE3XJ6LfFSidtP4qSFk88VknBcATu9mTOc+MZhn6W43ua3+aNp3/Q+PSwiPjKxNFn3ua2cQg8LTbGLlGQvkMciFPkBqxml+n0x7C+J8RoCPqYzwTabNcsLdhzuzqxtjHX7UGiZ7NuH7ETrZ/wbI5UJU7jupsOfoCGwEbVOuqpiWWmw7QhZ6nlfKFWUWNrDpJzsAiWATGUKat8C1axdyF/5ULWls1Ia2j0a33rHwFdf59uPDt4TeXGAJxW0Z/gIoc3+cbUu/ArHGC4r/39uYUwEQIVYzcw1m94M2/l7QhbpmCpc76+ycDoYa6qPFaFpNSPc4B42IGHQQB2kHJNlAhjU=;5:7OEJre5yRksC7/lxwC14L8zLINaauWbfTSkgkz+wuInzrWIxIM0woH9IMklNJy3GSZ5+62oN4TvZxrlwQFRhXC6HNlotYvDxfKFCWtlYOtTjKiHGRuFtve5iJQeaH+kKASxpt99ZtSfd2CWdPb8wag==;24:IzisdMxzZUmQmddGOK3hsGA+DX8FOtnmkvZLO8SBw9aJNQ+X6INFTzNY5yKiosTji4yuSiCjOoGj7EBtAXzvb6zKk9EVU4WpaRDjeFTpEsg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;7:+EvMaj1gfvEIki2kOMwM+0/dNpsVBwhQ7Q01YEkAFxLmAuTwuMImz8BSh9XLNqmpp1VI1hWr1nBkiXfljlr3Ypn2no6UDJSxzTHKuIQRTRQwn0c7rUUQ7Sxx577xWrSiAA471zndZcL4zRygg7qUddchWimgdx6rorl8zmiUFDPdygKw0T7THXwKtMoQ4692Aw6jeeFIHHNxRp1KttV2eJy/kXWrNlxmdBFiWFXZduBw6+XGmFY0oSwJEu3OGdRH0ANSBBJDp8u673S9RHbptlkosDsJDfnurcvE4lt6iEK9Qaf1BfC2tFvDrPaTKhSZvF+4sPxtfqvx8aM9Ysopj7KyFrn7GHOdpwwknQL4aO9D9HF/D+Hdkbv2RPe5Aolf9pM/x5nR3Dw/ZK2wCk+JqZ4ZNuoSQ4QFuq6RYddLhSrFH+QfTr3llPlMpylSey+akUC5NUBBv+/UEkehxi0w/g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 17:41:07.3337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1884 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00129.txt.bz2 Yao Qi writes: > On 16-12-09 07:46:25, Antoine Tremblay wrote: >> >> This situation is tested with non-stop-fair-events.exp. >> >> In other words, single-step breakpoints are installed in proceed_one_lwp >> for each thread. GDBserver proceeds two threads for resume_step, as >> requested by GDB, and the thread proceeded later may see the single-step >> breakpoints installed for the thread proceeded just now. >> >> Tested on gdbserver-native/-m{thumb,arm} no regressions. > > I assume this patch fixes fails in non-stop-fair-events.exp. No, it helps but fails are still present, to fix things you need https://sourceware.org/ml/gdb-patches/2016-11/msg00939.html and https://sourceware.org/ml/gdb-patches/2016-11/msg00940.html If you can take a look at those too it would be nice ? > >> >> gdb/gdbserver/ChangeLog: >> >> * linux-aarch32-low.c (arm_breakpoint_kind_from_pc): Use >> target_read_memory. >> * linux-arm-low.c (get_next_pcs_read_memory_unsigned_integer): Likewise. >> (get_next_pcs_syscall_next_pc): Likewise. > > Patch is good to me. Patch is pushed in.