Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Richard.Earnshaw@arm.com, Scott Bambrough <scottb@netwinder.org>,
	gdb-patches@sources.redhat.com
Subject: Re: RFA: fix rdi-share subdir selection in configure
Date: Wed, 19 Jan 2005 21:41:00 -0000	[thread overview]
Message-ID: <vt2wtu9umo6.fsf@zenia.home> (raw)
In-Reply-To: <20050119204129.GA13535@nevyn.them.org>


Daniel Jacobowitz <drow@false.org> writes:
> Two problems.
> 
> On Wed, Jan 19, 2005 at 03:31:39PM -0500, Jim Blandy wrote:
> >   			gdb_target=embed
> > !                         build_rdi_share=yes
> 
> My mailer says you've got the whitespace disease.

Hmm.  I think I've fixed that.  What's the rule?  Just to leave what
one found unchanged, or to always use tabs, or to never use tabs?

> I don't think the netware target wants the ARM RDI protocol...

I don't see why not.  It's friendly enough --- and pretty in pink.

2005-01-19  Jim Blandy  <jimb@redhat.com>

	* configure.tgt: Set build_rdi_share to "yes" on those targets
	that use that debugging protocol.
	Set build_nlm to yes to build NLM stub for Netware targets.
	* configure.ac: If build_rdi_share is "yes", then configure the
	rdi-share subdirectory.
	If build_nlm is "yes", the configure the "nlm" subdirectory.
        * configure: Regenerated.

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.157
diff -c -p -r1.157 configure.tgt
*** gdb/configure.tgt	7 Jan 2005 16:22:33 -0000	1.157
--- gdb/configure.tgt	19 Jan 2005 21:33:34 -0000
*************** arm*-*-netbsd* | arm*-*-knetbsd*-gnu)
*** 56,71 ****
  arm-*-nto*)		gdb_target=nto ;;
  arm*-*-* | thumb*-*-* | strongarm*-*-*)
  			gdb_target=embed
! 			# FIXME: cagney/2005-01-07: The configdirs
! 			# variable doesn't work with autoconf 2.59.
! 			# Disabled.
!                         # configdirs="$configdirs rdi-share"
                          ;;
  xscale-*-*)		gdb_target=embed
! 			# FIXME: cagney/2005-01-07: The configdirs
! 			# variable doesn't work with autoconf 2.59.
! 			# Disabled.
!                         # configdirs="$configdirs rdi-share"
                          ;;
  
  avr-*-*)		gdb_target=avr ;;
--- 56,65 ----
  arm-*-nto*)		gdb_target=nto ;;
  arm*-*-* | thumb*-*-* | strongarm*-*-*)
  			gdb_target=embed
! 			build_rdi_share=yes
                          ;;
  xscale-*-*)		gdb_target=embed
! 			build_rdi_share=yes
                          ;;
  
  avr-*-*)		gdb_target=avr ;;
*************** i[34567]86-*-linux*)	gdb_target=linux
*** 96,105 ****
  			;;
  i[34567]86-*-gnu*)	gdb_target=i386gnu ;;
  i[34567]86-*-netware*)	gdb_target=i386
! 			# FIXME: cagney/2005-01-07: The configdirs
! 			# variable doesn't work with autoconf 2.59.
! 			# Disabled.
! 			# configdirs="${configdirs} nlm"
  			;;
  i[34567]86-*-cygwin*)	gdb_target=cygwin  ;;
  i[34567]86-*-*)		gdb_target=i386 ;;
--- 90,96 ----
  			;;
  i[34567]86-*-gnu*)	gdb_target=i386gnu ;;
  i[34567]86-*-netware*)	gdb_target=i386
! 			build_nlm=yes
  			;;
  i[34567]86-*-cygwin*)	gdb_target=cygwin  ;;
  i[34567]86-*-*)		gdb_target=i386 ;;
Index: gdb/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.3
diff -c -p -r1.3 configure.ac
*** gdb/configure.ac	16 Jan 2005 22:51:49 -0000	1.3
--- gdb/configure.ac	19 Jan 2005 21:33:34 -0000
*************** if test "x$target" = "x$host"; then
*** 1508,1513 ****
--- 1508,1524 ----
    fi
  fi
  
+ # We build rdi-share on ARM-based targets, as instructed by configure.tgt.
+ if test "x$build_rdi_share" = xyes; then
+    AC_CONFIG_SUBDIRS(rdi-share)
+ fi
+ 
+ # We configure the nlm subdirectory on netware targets, as instructed
+ # by configure.tgt.
+ if test "x$build_nlm" = xyes; then
+    AC_CONFIG_SUBDIRS(nlm)
+ fi
+ 
  # If hostfile (XM_FILE) and/or targetfile (DEPRECATED_TM_FILE) and/or
  # nativefile (NAT_FILE) is not set in config/*/*.m[ht] files, we link
  # to an empty version.


  reply	other threads:[~2005-01-19 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19 20:37 Jim Blandy
2005-01-19 20:41 ` Daniel Jacobowitz
2005-01-19 21:41   ` Jim Blandy [this message]
2005-01-19 21:47     ` Daniel Jacobowitz
2005-01-19 22:05       ` Jim Blandy
2005-01-20  4:40     ` Eli Zaretskii
2005-01-19 21:53   ` Eli Zaretskii
2005-01-19 22:04     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2wtu9umo6.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=scottb@netwinder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox